Re: [PATCH] tools/libxl: include scheduler parameters in the output of xl list -l

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Jan 04, 2017 at 09:55:59AM +0000, Roger Pau Monne wrote:
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported-by: Fatih Acar <fatih@gandi.net>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> This should be backported to all supported stable branches (4.6, 4.7, 4.8).
> ---
>  tools/libxl/libxl.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 6fd4fe1..7aa6d41 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -6925,6 +6925,16 @@ int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid,
>          }
>      }
>  
> +    /* Scheduler params */
> +    {

Please add the following:

 libxl_sched_params_dispose(&d_config->b_info.sched_params);
 libxl_sched_params_init(&d_config->b_info.sched_params);

Also I would like to move this block before device handling.

> +        rc = libxl_domain_sched_params_get(ctx, domid,
> +                                           &d_config->b_info.sched_params);
> +        if (rc) {
> +            LOGD(ERROR, domid, "Fail to get scheduler parameters");
> +            goto out;
> +        }
> +    }
> +
>  out:
>      if (lock) libxl__unlock_domain_userdata(lock);
>      CTX_UNLOCK;
> -- 
> 2.10.1 (Apple Git-78)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel