All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sreekanth.Reddy@lsi.com
Cc: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: [bug report] [SCSI] mpt3sas: add new driver supporting 12GB SAS
Date: Wed, 4 Jan 2017 16:33:16 +0300	[thread overview]
Message-ID: <20170104133315.GA19973@elgon.mountain> (raw)

Hello Sreekanth Reddy,

The patch f92363d12359: "[SCSI] mpt3sas: add new driver supporting
12GB SAS" from Nov 30, 2012, leads to the following static checker
warning:

	drivers/scsi/mpt3sas/mpt3sas_base.c:620 _base_display_event_data()
	warn: curly braces intended?

drivers/scsi/mpt3sas/mpt3sas_base.c
   610          case MPI2_EVENT_SAS_DISCOVERY:
   611          {
   612                  Mpi2EventDataSasDiscovery_t *event_data =
   613                      (Mpi2EventDataSasDiscovery_t *)mpi_reply->EventData;
   614                  pr_info(MPT3SAS_FMT "Discovery: (%s)", ioc->name,
   615                      (event_data->ReasonCode == MPI2_EVENT_SAS_DISC_RC_STARTED) ?
   616                      "start" : "stop");
   617                  if (event_data->DiscoveryStatus)
   618                          pr_info("discovery_status(0x%08x)",
   619                              le32_to_cpu(event_data->DiscoveryStatus));
   620                          pr_info("\n");

The indenting is messed up here and also this should be using pr_cont()
because pr_info() will put a bunch of crap in the middle of the line.

   621                  return;
   622          }

regards,
dan carpenter

             reply	other threads:[~2017-01-04 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 13:33 Dan Carpenter [this message]
2017-01-04 13:52 ` [bug report] [SCSI] mpt3sas: add new driver supporting 12GB SAS Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104133315.GA19973@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=Sreekanth.Reddy@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.