From: Jean Delvare <jdelvare@suse.de>
To: Darren Hart <dvhart@infradead.org>, platform-driver-x86@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Michał Kępień" <kernel@kempniu.pl>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
Date: Wed, 4 Jan 2017 13:59:17 +0100 [thread overview]
Message-ID: <20170104135917.43eedcc0@endymion> (raw)
Dell-smbios is a helper module, it serves no purpose on its own, so
do not present it as an option to the user. Instead, select it
automatically whenever a driver which needs it is selected.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Michał Kępień <kernel@kempniu.pl>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more
user-friendly and avoids the confusing transitive dependencies
which Pali didn't like.
drivers/platform/x86/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-4.10-rc2.orig/drivers/platform/x86/Kconfig 2017-01-01 23:31:53.000000000 +0100
+++ linux-4.10-rc2/drivers/platform/x86/Kconfig 2017-01-04 13:53:41.691262664 +0100
@@ -92,8 +92,8 @@ config ASUS_LAPTOP
If you have an ACPI-compatible ASUS laptop, say Y or M here.
config DELL_SMBIOS
- tristate "Dell SMBIOS Support"
- depends on DCDBAS
+ tristate
+ select DCDBAS
default n
---help---
This module provides common functions for kernel modules using
@@ -103,12 +103,12 @@ config DELL_SMBIOS
config DELL_LAPTOP
tristate "Dell Laptop Extras"
- depends on DELL_SMBIOS
depends on DMI
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on RFKILL || RFKILL = n
depends on SERIO_I8042
+ select DELL_SMBIOS
select POWER_SUPPLY
select LEDS_CLASS
select NEW_LEDS
@@ -123,7 +123,7 @@ config DELL_WMI
depends on DMI
depends on INPUT
depends on ACPI_VIDEO || ACPI_VIDEO = n
- depends on DELL_SMBIOS
+ select DELL_SMBIOS
select INPUT_SPARSEKMAP
---help---
Say Y here if you want to support WMI-based hotkeys on Dell laptops.
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2017-01-04 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 12:59 Jean Delvare [this message]
2017-01-04 13:14 ` [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Andy Shevchenko
2017-01-05 8:12 ` Jean Delvare
2017-01-05 8:59 ` Pali Rohár
2017-01-05 9:09 ` Jean Delvare
2017-01-05 9:10 ` Pali Rohár
2017-01-05 21:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104135917.43eedcc0@endymion \
--to=jdelvare@suse.de \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.