From: Jiri Olsa <jolsa@redhat.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] tools: perf: fix linker error when libelf config is disabled
Date: Wed, 4 Jan 2017 15:45:37 +0100 [thread overview]
Message-ID: <20170104144537.GB4908@krava> (raw)
In-Reply-To: <1483537960-14499-1-git-send-email-sudeep.holla@arm.com>
On Wed, Jan 04, 2017 at 01:52:40PM +0000, Sudeep Holla wrote:
> When libelf is disabled in the configuration, we get the following
> linker error:
> LINK libperf-jvmti.so
> ld: cannot find -lelf
> Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed
>
> This patch fixes the error by using the configuration macro EXTLIBS.
>
> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> tools/perf/Makefile.perf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 8fc24824705e..6defd9b00bc4 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -512,7 +512,7 @@ $(LIBJVMTI_IN): FORCE
> $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti
>
> $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
> - $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
> + $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< $(EXTLIBS) -lrt
> endif
hm, do we need -lelf -lrt at all? can't see reason for that
jirka
next prev parent reply other threads:[~2017-01-04 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 13:52 [PATCH] tools: perf: fix linker error when libelf config is disabled Sudeep Holla
2017-01-04 14:45 ` Jiri Olsa [this message]
2017-01-04 15:45 ` Sudeep Holla
2017-01-04 15:56 ` [PATCH v2] " Sudeep Holla
2017-01-04 16:06 ` Jiri Olsa
2017-01-04 16:08 ` Sudeep Holla
2017-01-04 16:18 ` Sudeep Holla
2017-01-04 17:19 ` Jiri Olsa
2017-01-04 17:26 ` Sudeep Holla
2017-01-04 17:30 ` [PATCH v3] " Sudeep Holla
2017-01-04 17:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104144537.GB4908@krava \
--to=jolsa@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.