From: "Daniel P. Berrange" <berrange@redhat.com>
To: Nathan Rossi <nathan@nathanrossi.com>
Cc: qemu-devel@nongnu.org, Alistair Francis <alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH] configure: For libgcrypt if pkg-config is available use it
Date: Wed, 4 Jan 2017 15:27:31 +0000 [thread overview]
Message-ID: <20170104152731.GF10541@redhat.com> (raw)
In-Reply-To: <20170104145652.30442-1-nathan@nathanrossi.com>
On Thu, Jan 05, 2017 at 12:56:52AM +1000, Nathan Rossi wrote:
> If libgcrypt info is available with pkg-config use it over using the
> libgcrypt-config. pkg-config is preferred due to is compatibility with
> cross-compilation (where you cannot execute the targets version of
> libgcrypt-config).
It can be made to work, but you need to modify $PATH to ensure it finds
the build target libgcrypt-config first.
eg on Fedora you'd do this with mingw32
PATH=/usr/i686-w64-mingw32/sys-root/mingw/bin:$PATH ./configure ...
> This change makes configure check for libgcrypt in pkg-config first,
> then falling back to use libgcrypt-config if available. This follows a
> similar process to how libsdl is handled.
AFAIK, no version of libgcrypt has ever shipped a pkg-config file. Their
maintainers have explicitly rejected patches adding that, ironically
because they claim pkg-config doesn't handle cross-compilation and
libgcrypt-config does :-)
https://lists.gnupg.org/pipermail/gcrypt-devel/2007-February/001109.html
https://lists.gnupg.org/pipermail/gcrypt-devel/2015-September/003569.html
So overall, I don't think this patch is needed/desirable for QEMU.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-01-04 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 14:56 [Qemu-devel] [PATCH] configure: For libgcrypt if pkg-config is available use it Nathan Rossi
2017-01-04 15:27 ` Daniel P. Berrange [this message]
2017-01-04 16:01 ` Nathan Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104152731.GF10541@redhat.com \
--to=berrange@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=nathan@nathanrossi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.