From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm_fourcc: Add new P010 video format Date: Wed, 4 Jan 2017 17:56:32 +0200 Message-ID: <20170104155632.GI31595@intel.com> References: <1483347004-32593-1-git-send-email-ayaka@soulik.info> <1483347004-32593-2-git-send-email-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FB4C6E75F for ; Wed, 4 Jan 2017 15:56:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1483347004-32593-2-git-send-email-ayaka@soulik.info> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Li Cc: randy.li@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMDIsIDIwMTcgYXQgMDQ6NTA6MDNQTSArMDgwMCwgUmFuZHkgTGkgd3JvdGU6 Cj4gUDAxMCBpcyBhIHBsYW5hciA0OjI6MCBZVVYgd2l0aCBpbnRlcmxlYXZlZCBVViBwbGFuZSwg MTAgYml0cwo+IHBlciBjaGFubmVsIHZpZGVvIGZvcm1hdC4gUm9ja2NoaXAncyB2b3Agc3VwcG9y dCB0aGlzCj4gdmlkZW8gZm9ybWF0KGxpdHRsZSBlbmRpYW4gb25seSkgYXMgdGhlIGlucHV0IHZp ZGVvIGZvcm1hdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYW5keSBMaSA8YXlha2FAc291bGlrLmlu Zm8+Cj4gLS0tCj4gIGluY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oIHwgMSArCj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkv ZHJtL2RybV9mb3VyY2MuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gaW5kZXgg OWUxYmI3Zi4uZDI3MjFkYSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3Vy Y2MuaAo+ICsrKyBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gQEAgLTExOSw2ICsx MTksNyBAQCBleHRlcm4gIkMiIHsKPiAgI2RlZmluZSBEUk1fRk9STUFUX05WNjEJCWZvdXJjY19j b2RlKCdOJywgJ1YnLCAnNicsICcxJykgLyogMngxIHN1YnNhbXBsZWQgQ2I6Q3IgcGxhbmUgKi8K PiAgI2RlZmluZSBEUk1fRk9STUFUX05WMjQJCWZvdXJjY19jb2RlKCdOJywgJ1YnLCAnMicsICc0 JykgLyogbm9uLXN1YnNhbXBsZWQgQ3I6Q2IgcGxhbmUgKi8KPiAgI2RlZmluZSBEUk1fRk9STUFU X05WNDIJCWZvdXJjY19jb2RlKCdOJywgJ1YnLCAnNCcsICcyJykgLyogbm9uLXN1YnNhbXBsZWQg Q2I6Q3IgcGxhbmUgKi8KPiArI2RlZmluZSBEUk1fRk9STUFUX1AwMTAJCWZvdXJjY19jb2RlKCdQ JywgJzAnLCAnMScsICcwJykgLyogMngyIHN1YnNhbXBsZWQgQ3I6Q2IgcGxhbmUgMTAgYml0cyBw ZXIgY2hhbm5lbCAqLwoKV2UgY291bGQgdXNlIGEgYmV0dGVyIGRlc2NyaXB0aW9uIG9mIHRoZSBm b3JtYXQgaGVyZS4gSUlSQyB0aGVyZSBpcwoxMGJpdHMgb2YgYWN0dWFsIGRhdGEgY29udGFpbmVk IGluIGVhY2ggMTZiaXRzLiBTbyB0aGVyZSBzaG91bGQgYmUgYQpwcm9wZXIgY29tbWVudCBleHBs YW5pbmcgaW4gd2hpY2ggd2F5IHRoZSBiaXRzIGFyZSBzdG9yZWQuCgo+ICAKPiAgLyoKPiAgICog MyBwbGFuZSBZQ2JDcgo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9U QwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga06.intel.com ([134.134.136.31]:58737 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967226AbdADP4h (ORCPT ); Wed, 4 Jan 2017 10:56:37 -0500 Date: Wed, 4 Jan 2017 17:56:32 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Randy Li Cc: dri-devel@lists.freedesktop.org, randy.li@rock-chips.com, linux-kernel@vger.kernel.org, daniel.vetter@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 1/2] drm_fourcc: Add new P010 video format Message-ID: <20170104155632.GI31595@intel.com> References: <1483347004-32593-1-git-send-email-ayaka@soulik.info> <1483347004-32593-2-git-send-email-ayaka@soulik.info> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1483347004-32593-2-git-send-email-ayaka@soulik.info> Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, Jan 02, 2017 at 04:50:03PM +0800, Randy Li wrote: > P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits > per channel video format. Rockchip's vop support this > video format(little endian only) as the input video format. > > Signed-off-by: Randy Li > --- > include/uapi/drm/drm_fourcc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 9e1bb7f..d2721da 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -119,6 +119,7 @@ extern "C" { > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > +#define DRM_FORMAT_P010 fourcc_code('P', '0', '1', '0') /* 2x2 subsampled Cr:Cb plane 10 bits per channel */ We could use a better description of the format here. IIRC there is 10bits of actual data contained in each 16bits. So there should be a proper comment explaning in which way the bits are stored. > > /* > * 3 plane YCbCr > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC