From: Will Deacon <will.deacon@arm.com>
To: Andy Gross <andy.gross@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com,
Kevin Hilman <khilman@baylibre.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux@armlinux.org.uk
Subject: Re: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls
Date: Wed, 4 Jan 2017 17:33:46 +0000 [thread overview]
Message-ID: <20170104173346.GN18193@arm.com> (raw)
In-Reply-To: <1483054046-3327-3-git-send-email-andy.gross@linaro.org>
On Thu, Dec 29, 2016 at 05:27:26PM -0600, Andy Gross wrote:
> This patch adds a Qualcomm specific quirk to the arm_smccc_smc call.
>
> On Qualcomm ARM64 platforms, the SMC call can return before it has
> completed. If this occurs, the call can be restarted, but it requires
> using the returned session ID value from the interrupted SMC call.
>
> The quirk stores off the session ID from the interrupted call in the
> quirk structure so that it can be used by the caller.
>
> This patch folds in a fix given by Sricharan R:
> https://lkml.org/lkml/2016/9/28/272
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
> arch/arm64/kernel/smccc-call.S | 9 ++++++++-
> drivers/firmware/qcom_scm-64.c | 13 ++++++++++---
> include/linux/arm-smccc.h | 11 ++++++++---
> 3 files changed, 26 insertions(+), 7 deletions(-)
Reviewed-by: Will Deacon <will.deacon@arm.com>
Thanks for sticking with this, it looks good to me now.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls
Date: Wed, 4 Jan 2017 17:33:46 +0000 [thread overview]
Message-ID: <20170104173346.GN18193@arm.com> (raw)
In-Reply-To: <1483054046-3327-3-git-send-email-andy.gross@linaro.org>
On Thu, Dec 29, 2016 at 05:27:26PM -0600, Andy Gross wrote:
> This patch adds a Qualcomm specific quirk to the arm_smccc_smc call.
>
> On Qualcomm ARM64 platforms, the SMC call can return before it has
> completed. If this occurs, the call can be restarted, but it requires
> using the returned session ID value from the interrupted SMC call.
>
> The quirk stores off the session ID from the interrupted call in the
> quirk structure so that it can be used by the caller.
>
> This patch folds in a fix given by Sricharan R:
> https://lkml.org/lkml/2016/9/28/272
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
> arch/arm64/kernel/smccc-call.S | 9 ++++++++-
> drivers/firmware/qcom_scm-64.c | 13 ++++++++++---
> include/linux/arm-smccc.h | 11 ++++++++---
> 3 files changed, 26 insertions(+), 7 deletions(-)
Reviewed-by: Will Deacon <will.deacon@arm.com>
Thanks for sticking with this, it looks good to me now.
Will
next prev parent reply other threads:[~2017-01-04 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 23:27 [Patch v2 0/2] Support ARM SMCC SoC vendor quirks Andy Gross
2016-12-29 23:27 ` Andy Gross
2016-12-29 23:27 ` [Patch v2 1/2] arm: kernel: Add SMC structure parameter Andy Gross
2016-12-29 23:27 ` Andy Gross
2017-01-04 17:33 ` Will Deacon
2017-01-04 17:33 ` Will Deacon
2016-12-29 23:27 ` [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls Andy Gross
2016-12-29 23:27 ` Andy Gross
2017-01-04 17:33 ` Will Deacon [this message]
2017-01-04 17:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104173346.GN18193@arm.com \
--to=will.deacon@arm.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.