From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v3] xfstests-bld: correct file permissions on test appliance files
Date: Wed, 4 Jan 2017 16:29:15 -0800 [thread overview]
Message-ID: <20170105002915.GD21696@gmail.com> (raw)
In-Reply-To: <20161228210820.13832-1-ebiggers3@gmail.com>
On Wed, Dec 28, 2016 at 03:08:20PM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The xfstests-bld repository may have been cloned with a umask that
> masked out the group and/or the other bits. When using --update-files
> in this situation or when creating a GCE image, the VM ended up in a
> state where non-root users were unable to execute anything, which made
> all tests using the fsgqa user get skipped. Fix this by copying the r
> and x user bits to the group and other bits when creating files.tar.gz.
> Also set the owner and group to root while we're at it.
>
> Note that git doesn't actually store file owners, groups, or any mode
> bits other than "is the file executable"? So this patch really just
> enforces a consistent, sane default for this "unstored" metadata.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
As it turns out, update_xfstests() in kvm-xfstests/test-appliance/gen-image also
needs to be updated. (I'm not sure why it wasn't a problem for me before.) So
I'll send yet another version of this patch.
Eric
prev parent reply other threads:[~2017-01-05 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 21:08 [PATCH v3] xfstests-bld: correct file permissions on test appliance files Eric Biggers
2017-01-05 0:29 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105002915.GD21696@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.