Re: [PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Vinod Koul <vinod.koul@intel.com>]

On Wed, Jan 04, 2017 at 03:22:13PM +0300, Alexandrov Stansilav wrote:
> Signed-off-by: Alexandrov Stansilav <neko@nya.ai>

Same comments here too, the title and log doesn't tell me the changes in the
patch.

So a better title could be:

ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

And log may contain:

HP Pavilion x2 10-p000 sports a rt5640 codec, bit with ACPI ID 10EC5640, so
add a new entry in machine table for this configuration.

> ---
>  sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
> index f4d92bb..896ced2 100644
> --- a/sound/soc/intel/atom/sst/sst_acpi.c
> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
> @@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
>  	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
>  	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
>  						&chv_platform_data },
> +	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
> +						&chv_platform_data },
>  
>  	{},
>  };
> -- 
> 2.10.2
> 

-- 
~Vinod