All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bruce James Fields <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Trond Myklebust <trondmy@gmail.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [nfsv4] RFC 7530: Filehandle of opened file after the REMOVE
Date: Thu, 5 Jan 2017 06:51:30 +0100	[thread overview]
Message-ID: <20170105055130.GA10939@lst.de> (raw)
In-Reply-To: <20170104174245.GD17649@fieldses.org>

On Wed, Jan 04, 2017 at 12:42:45PM -0500, Bruce James Fields wrote:
> Dumb question: don't local filesystems have the ability to do some sort
> of emergency conversion to read-only on detecting corruption?

Yes.

> Does that
> prevent any open-file cleanup?

Yes, at least before the reboot.

> If not that, is there some other
> mechanism nfsd could use to crash the filesystem on shutdown if
> appropriate (so if it's holding opens on a filesystem and if the
> filesystem was mounted with the new option)?
> 
> Possibly better would be if we could keep a separate list of
> unlinked-but-still-held-by-nfsd files that was managed diferently than
> the existing list.
> 
> But, I don't have the local filesystem knowledge to know where the
> nightmares are here.

Maybe I shouldn't have called it a nighmare, but it's significantly
more effort.  We'll need a way for NFSD to mark a file as not being
allowed to cleaned up before the final iput for the reboot case
mostly.

I'll try to come up with a prototype later this month, but it might not
be pretty.

  reply	other threads:[~2017-01-05  5:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAABAsM5L0xdKodxk1dRSugLyROzn2JzgDkq6kdHE0LuGcfh++A@mail.gmail.com>
     [not found] ` <20161213181734.Horde.EqgB09El8rupnkesIQaBwJ3@mail.telka.sk>
     [not found]   ` <CADaq8jcq2C0o8EWXoGjxDn58sV_J+-SP-=rj934Se-DV69b-pw@mail.gmail.com>
     [not found]     ` <20161214112112.Horde.aPh8AjT6iWRl37CULwihyV7@mail.telka.sk>
     [not found]       ` <CAABAsM7v6y0bsb0jKzfvobkUjniTLhM3uv8FYjo07HcLD2004w@mail.gmail.com>
     [not found]         ` <20161227144414.GA32002@fieldses.org>
     [not found]           ` <CADaq8jck14SKL6Ua9QxbqPyX1=1aaA7+76wv-__EWFvh7ZcEJA@mail.gmail.com>
     [not found]             ` <C496AE44-0F27-4B66-A1F6-A76AEAFD7A90@gmail.com>
     [not found]               ` <20161229024703.GA21325@fieldses.org>
     [not found]                 ` <20161229074830.GA3002@lst.de>
2016-12-29 20:54                   ` [nfsv4] RFC 7530: Filehandle of opened file after the REMOVE Bruce James Fields
2016-12-30  8:35                     ` Christoph Hellwig
2017-01-01 13:58                       ` Christoph Hellwig
2017-01-01 22:10                         ` Bruce James Fields
2017-01-02  8:40                           ` Christoph Hellwig
2017-01-02 15:27                             ` Bruce James Fields
2017-01-04 17:42                               ` Bruce James Fields
2017-01-05  5:51                                 ` Christoph Hellwig [this message]
2017-01-06 21:13                                   ` Bruce James Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170105055130.GA10939@lst.de \
    --to=hch@lst.de \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.