From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S968391AbdAEH7c (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 02:59:32 -0500
Received: from mail-wj0-f196.google.com ([209.85.210.196]:34491 "EHLO
        mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760468AbdAEH7X (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 02:59:23 -0500
Date: Thu, 5 Jan 2017 08:59:14 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel@vger.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>, Dou Liyang <douly.fnst@cn.fujitsu.com>,
        Nicolai Stange <nicstange@gmail.com>,
        Gu Zheng <guz.fnst@cn.fujitsu.com>, Baoquan He <bhe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Claudio Fontana <claudio.fontana@huawei.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
        linux-edac@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform
 IRQ handlers
Message-ID: <20170105075914.GB2098@gmail.com>
References: <059fdf437c2f0c09b13c18c8fe4e69999d3ffe69.1483528431.git.bristot@redhat.com>
 <20170104100800.334a9a0e@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170104100800.334a9a0e@gandalf.local.home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed,  4 Jan 2017 12:20:33 +0100
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> 
> > This patch adds the __irq_entry annotation to the defaults x86's
> > platform IRQ handlers. ftrace's function_graph tracer uses the
> > __irq_entry annotation to notify the entry and return of IRQ
> > handlers.
> > 
> > For example, before the patch:
> >   354549.667252 |   3)  d..1              |  default_idle_call() {
> >   354549.667252 |   3)  d..1              |    arch_cpu_idle() {
> >   354549.667253 |   3)  d..1              |      default_idle() {
> >   354549.696886 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
> >   354549.696886 |   3)  d..1              |          irq_enter() {
> >   354549.696886 |   3)  d..1              |            rcu_irq_enter() {
> > 
> > After the patch:
> >   366416.254476 |   3)  d..1              |    arch_cpu_idle() {
> >   366416.254476 |   3)  d..1              |      default_idle() {
> >   366416.261566 |   3)  d..1  ==========> |
> >   366416.261566 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
> >   366416.261566 |   3)  d..1              |          irq_enter() {
> >   366416.261566 |   3)  d..1              |            rcu_irq_enter() {
> > 
> > KASAN also uses this annotation. The smp_apic_timer_interrupt
> > was already annotated.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Thomas or Ingo, want to take this in tip?

Yeah, queued it up for v4.11.

Thanks,

	Ingo