From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: VT switch broken with docking station DP Date: Thu, 5 Jan 2017 17:59:31 +0200 Message-ID: <20170105155931.GT31595@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3657A6E8AF for ; Thu, 5 Jan 2017 15:59:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKYW4gMDUsIDIwMTcgYXQgMDQ6Mzc6MjdQTSArMDEwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IEhpLAo+IAo+IHJlY2VudGx5IEkgbm90aWNlZCB0aGF0IFZUIGNvbnNvbGUgZG9lc24n dCB3b3JrIGFueSBsb25nZXIgd2hlbiBJIGRvY2sKPiBhIERlbGwgRTcyNzAgbGFwdG9wIHdpdGgg YSBEUCBtb25pdG9yLiAgVGhlIGJ1ZyBkZXRhaWwgaXMgbGlrZSB0aGlzOgo+IAo+IEF0IGZpcnN0 LCBJIGJvb3QgdGhlIGxhcHRvcCB3aXRob3V0IGRvY2suICBJIGNhbiBzd2l0Y2ggYmV0d2VlbiBY IGFuZAo+IFZUIHZpYSBjdHJsLWFsdC1GMSwgc28gZmFyLiAgVGhlbiBJIGRvY2sgaXQgdG8gYSBk b2NraW5nIHN0YXRpb24KPiBjb25uZWN0ZWQgd2l0aCBhIERQIG1vbml0b3IuICBOb3csIHdoZW4g SSBzd2l0Y2ggdG8gVlQsIGl0IGJlaGF2ZXMgYXMKPiBpZiBmcm96ZW4sIHRoZSBYIGdyYXBoaWNz IHNjcmVlbiByZW1haW5zLiAgQnV0IGFjdHVhbGx5IGl0J3Mgb25seQo+IGdyYXBoaWNzIGFuZCB0 aGUga2V5Ym9hcmQgaW5wdXQgaXMgcHJvY2Vzc2VkIGluIFZULiAgSSBjYW4gZ28gYmFjayB0bwo+ IFggdmlhIGFsdC1GNyBhZ2Fpbi4gIFRoZSBzaXR1YXRpb24gcmVtYWlucyB1bnRpbCBJIHVuZG9j ayBhbmQgSSBraWxsIFgKPiBvbmNlLgo+IAo+IEFmdGVyIGxvb2tpbmcgbW9yZSBkZWVwbHkgYXQg ZHJtIGRlYnVnIGxvZywgSSBmb3VuZCBvdXQgdGhhdCBpdCdzCj4gY2F1c2VkIGJ5IHRoZSBkcm0g YXRvbWljIGNoZWNrLiAgRXNzZW50aWFsbHksIGl0J3MgYmVjYXVzZSBlRFAgaGFzIHRoZQo+IGxv d2VyIHJlc29sdXRpb24gKDEzNjZ4NzY4KSB0aGFuIERQICgxOTIweDEwODApLiAgU2luY2UgYm9v dGluZyB3aXRoCj4gZURQLCB0aGUgZnJhbWUgYnVmZmVyIHNpemUgaXMgMTM2Nng3NjguICBUaGVu IGl0IGhpdHMgdGhlIGZvbGxvd2luZwo+IGNoZWNrIGluIGRybV9hdG9taWNfcGxhbmVfY2hlY2so KToKPiAKPiAJZmJfd2lkdGggPSBzdGF0ZS0+ZmItPndpZHRoIDw8IDE2Owo+IAlmYl9oZWlnaHQg PSBzdGF0ZS0+ZmItPmhlaWdodCA8PCAxNjsKPiAKPiAJLyogTWFrZSBzdXJlIHNvdXJjZSBjb29y ZGluYXRlcyBhcmUgaW5zaWRlIHRoZSBmYi4gKi8KPiAJaWYgKHN0YXRlLT5zcmNfdyA+IGZiX3dp ZHRoIHx8Cj4gCSAgICBzdGF0ZS0+c3JjX3ggPiBmYl93aWR0aCAtIHN0YXRlLT5zcmNfdyB8fAo+ IAkgICAgc3RhdGUtPnNyY19oID4gZmJfaGVpZ2h0IHx8Cj4gCSAgICBzdGF0ZS0+c3JjX3kgPiBm Yl9oZWlnaHQgLSBzdGF0ZS0+c3JjX2gpIHsKPiAJCURSTV9ERUJVR19BVE9NSUMoIkludmFsaWQg c291cmNlIGNvb3JkaW5hdGVzICIKPiAJCQkJICIldS4lMDZ1eCV1LiUwNnUrJXUuJTA2dSsldS4l MDZ1XG4iLAo+IAkJCQkgc3RhdGUtPnNyY193ID4+IDE2LCAoKHN0YXRlLT5zcmNfdyAmIDB4ZmZm ZikgKiAxNTYyNSkgPj4gMTAsCj4gCQkJCSBzdGF0ZS0+c3JjX2ggPj4gMTYsICgoc3RhdGUtPnNy Y19oICYgMHhmZmZmKSAqIDE1NjI1KSA+PiAxMCwKPiAJCQkJIHN0YXRlLT5zcmNfeCA+PiAxNiwg KChzdGF0ZS0+c3JjX3ggJiAweGZmZmYpICogMTU2MjUpID4+IDEwLAo+IAkJCQkgc3RhdGUtPnNy Y195ID4+IDE2LCAoKHN0YXRlLT5zcmNfeSAmIDB4ZmZmZikgKiAxNTYyNSkgPj4gMTApOwo+IAkJ cmV0dXJuIC1FTk9TUEM7Cj4gCX0KPiAKPiBBY3R1YWxseSBhZnRlciBjb21tZW50aW5nIG91dCAi cmV0dXJuIC1FTk9TUEMiLCBWVCBzd2l0Y2ggd29ya3MgZmluZS4KPiAKPiBCdXQgdGhlIGNvZGUg YWJvdmUgbWFkZSBtZSB3b25kZXIgd2hhdCdzIHRoZSByZXF1aXJlbWVudCBoZXJlLiAgSUlSQywK PiB0aGUgVlQgYWx3YXlzIHdvcmtlZCBvbiBhIGRpc3BsYXkgd2l0aCBhIGhpZ2hlciByZXNvbHV0 aW9uIGV2ZW4gaWYgdGhlCj4gZnJhbWUgYnVmZmVyIGlzIHNtYWxsZXIuICBPbmx5IGEgcGFydCBv ZiBkaXNwbGF5IHdhcyB1c2VkLCBidXQgaXQgd2FzCj4gT0ssIGZhciBiZXR0ZXIgdGhhbiB0aGUg ZnJvemVuIGdyYXBoaWNzIDopCj4gCj4gQ2FuIHdlIHNpbXBseSBkcm9wIHRoaXMgY2hlY2ssIG9y IG1heSB3ZSBhZGQgYSBmbGFnIHRvIHNraXAgaXQgZm9yIFZUCj4gc3dpdGNoaW5nPyAgT3IgYW55 IGJldHRlciBpZGVhPwoKRmluZCBvdXQgd2h5IGl0IGRpZG4ndCBhbGxvY2F0ZSBhIGJpZyBlbm91 Z2ggZnJhbWVidWZmZXIgdG8gYmVnaW4gd2l0aCwKb3IgYWx0ZXJuYXRpdmVseSB3aHkgaXQgdHJp ZWQgdG8gc3BlY2lmeSBzb3VyY2UgY29vcmRpbmF0ZXMgZXhjZWVkaW5nCnRoZSBmYiBkaW1lbnNp b25zLgoKVGhlcmUgaXMgY2xlYXJseSBhIGJ1ZyBzb21ld2hlcmUsIGp1c3Qgbm90IGhlcmUuCgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937148AbdAEP7l (ORCPT ); Thu, 5 Jan 2017 10:59:41 -0500 Received: from mga06.intel.com ([134.134.136.31]:4647 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932903AbdAEP7f (ORCPT ); Thu, 5 Jan 2017 10:59:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,322,1477983600"; d="scan'208";a="26584387" Date: Thu, 5 Jan 2017 17:59:31 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Takashi Iwai Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: VT switch broken with docking station DP Message-ID: <20170105155931.GT31595@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 04:37:27PM +0100, Takashi Iwai wrote: > Hi, > > recently I noticed that VT console doesn't work any longer when I dock > a Dell E7270 laptop with a DP monitor. The bug detail is like this: > > At first, I boot the laptop without dock. I can switch between X and > VT via ctrl-alt-F1, so far. Then I dock it to a docking station > connected with a DP monitor. Now, when I switch to VT, it behaves as > if frozen, the X graphics screen remains. But actually it's only > graphics and the keyboard input is processed in VT. I can go back to > X via alt-F7 again. The situation remains until I undock and I kill X > once. > > After looking more deeply at drm debug log, I found out that it's > caused by the drm atomic check. Essentially, it's because eDP has the > lower resolution (1366x768) than DP (1920x1080). Since booting with > eDP, the frame buffer size is 1366x768. Then it hits the following > check in drm_atomic_plane_check(): > > fb_width = state->fb->width << 16; > fb_height = state->fb->height << 16; > > /* Make sure source coordinates are inside the fb. */ > if (state->src_w > fb_width || > state->src_x > fb_width - state->src_w || > state->src_h > fb_height || > state->src_y > fb_height - state->src_h) { > DRM_DEBUG_ATOMIC("Invalid source coordinates " > "%u.%06ux%u.%06u+%u.%06u+%u.%06u\n", > state->src_w >> 16, ((state->src_w & 0xffff) * 15625) >> 10, > state->src_h >> 16, ((state->src_h & 0xffff) * 15625) >> 10, > state->src_x >> 16, ((state->src_x & 0xffff) * 15625) >> 10, > state->src_y >> 16, ((state->src_y & 0xffff) * 15625) >> 10); > return -ENOSPC; > } > > Actually after commenting out "return -ENOSPC", VT switch works fine. > > But the code above made me wonder what's the requirement here. IIRC, > the VT always worked on a display with a higher resolution even if the > frame buffer is smaller. Only a part of display was used, but it was > OK, far better than the frozen graphics :) > > Can we simply drop this check, or may we add a flag to skip it for VT > switching? Or any better idea? Find out why it didn't allocate a big enough framebuffer to begin with, or alternatively why it tried to specify source coordinates exceeding the fb dimensions. There is clearly a bug somewhere, just not here. -- Ville Syrjälä Intel OTC