[PATCH] usb: storage: ene_ub6250: remove unused variable

[PATCH] usb: storage: ene_ub6250: remove unused variable

[Sudip Mukherjee]

The variable Newblk was only being assigned some value but was never
used after that.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/usb/storage/ene_ub6250.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 02bdaa9..369f3c2 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -1364,7 +1364,6 @@ static int ms_lib_read_extra(struct us_data *us, u32 PhyBlock,
 
 static int ms_libsearch_block_from_physical(struct us_data *us, u16 phyblk)
 {
-	u16 Newblk;
 	u16 blk;
 	struct ms_lib_type_extdat extdat; /* need check */
 	struct ene_ub6250_info *info = (struct ene_ub6250_info *) us->extra;
@@ -1377,7 +1376,6 @@ static int ms_libsearch_block_from_physical(struct us_data *us, u16 phyblk)
 		if ((blk & MS_PHYSICAL_BLOCKS_PER_SEGMENT_MASK) == 0)
 			blk -= MS_PHYSICAL_BLOCKS_PER_SEGMENT;
 
-		Newblk = info->MS_Lib.Phy2LogMap[blk];
 		if (info->MS_Lib.Phy2LogMap[blk] == MS_LB_NOT_USED_ERASED) {
 			return blk;
 		} else if (info->MS_Lib.Phy2LogMap[blk] == MS_LB_NOT_USED) {
-- 
1.9.1

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

[Greg Kroah-Hartman]

On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> The variable Newblk was only being assigned some value but was never
> used after that.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/usb/storage/ene_ub6250.c | 2 --
>  1 file changed, 2 deletions(-)

from and signed-off-by does not match :(

Same with your other usb patch...

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

[Sudip Mukherjee]

On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
>> The variable Newblk was only being assigned some value but was never
>> used after that.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>>   drivers/usb/storage/ene_ub6250.c | 2 --
>>   1 file changed, 2 deletions(-)
>
> from and signed-off-by does not match :(
>
> Same with your other usb patch...
>

I can add the From: tag in the patch. But this is from the last time we 
had this same conversation.

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html


Regards
Sudip

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

[Greg Kroah-Hartman]

On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > > ---
> > >   drivers/usb/storage/ene_ub6250.c | 2 --
> > >   1 file changed, 2 deletions(-)
> > 
> > from and signed-off-by does not match :(
> > 
> > Same with your other usb patch...
> > 
> 
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
> 
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html

I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.

I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)

thanks,

greg k-h