From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [morty][PATCH] systemtap: remove explicit msgfmt check
Date: Thu, 5 Jan 2017 14:16:52 -0500 [thread overview]
Message-ID: <20170105191652.GN30576@denix.org> (raw)
In-Reply-To: <1482437940-4194-1-git-send-email-denis@denix.org>
Ping.
On Thu, Dec 22, 2016 at 03:19:00PM -0500, Denys Dmytriyenko wrote:
> From: Ross Burton <ross.burton@intel.com>
>
> Passing --disable-nls should be enough to disable the requirement for a full
> gettext to be present, but the upstream configure explicitly checks for msgfmt
> even if it isn't going to be used. To avoid having to depend on gettext-native,
> patch this check out.
>
> (From OE-Core rev: 2f8d2a74f73490c1ae35131d3eb3592f7ee0a1e4)
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> .../systemtap/systemtap/no-msgfmt-check.patch | 15 +++++++++++++++
> meta/recipes-kernel/systemtap/systemtap_git.inc | 1 +
> 2 files changed, 16 insertions(+)
> create mode 100644 meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
>
> diff --git a/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch b/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
> new file mode 100644
> index 0000000..471e62c
> --- /dev/null
> +++ b/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
> @@ -0,0 +1,15 @@
> +There is no need to explicitly check that msgfmt was found as the gettext macros
> +handle this for us if NLS is enabled.
> +
> +Upstream-Status: Pending
> +Signed-off-by: Ross Burton <ross.burton@intel.com>
> +
> +diff --git a/configure.ac b/configure.ac
> +index e56079a..284bbe0 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -39,4 +38,0 @@ AM_GNU_GETTEXT_VERSION([0.19.4])
> +-if test "x$GMSGFMT" = "x:"; then
> +- AC_MSG_ERROR([missing gnu /usr/bin/msgfmt])
> +-fi
> +-
> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
> index 304eb99..34cf227 100644
> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> @@ -9,6 +9,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git \
> file://configure-allow-to-disable-libvirt.patch \
> file://x32_abi_time.patch \
> file://monitor-option.patch \
> + file://no-msgfmt-check.patch \
> "
>
> # systemtap doesn't support mips
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2017-01-05 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 20:19 [morty][PATCH] systemtap: remove explicit msgfmt check Denys Dmytriyenko
2017-01-05 19:16 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105191652.GN30576@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.