From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] linux-dtb: strip DTB extension properly in postinst/postrm
Date: Thu, 5 Jan 2017 15:18:30 -0500 [thread overview]
Message-ID: <20170105201830.GP30576@denix.org> (raw)
In-Reply-To: <1482351617-31989-1-git-send-email-denis@denix.org>
Ping.
On Wed, Dec 21, 2016 at 03:20:17PM -0500, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
>
> The use of awk -F "." in do_install/do_deploy to strip filename extension
> was deprecated long time ago in 72980d5bb465f0640ed451d1ebb9c5d2a210ad0c.
>
> Make a similar change in postinst/postrm to properly use basename command.
>
> Otherwise DTB files that contain dots in the name result in broken symlinks
> that point to non-existent truncated files.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> meta/recipes-kernel/linux/linux-dtb.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index 8528d64..2f378a1 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -68,7 +68,7 @@ pkg_postinst_kernel-devicetree () {
> for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> DTB_EXT=${DTB##*.}
> - DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
> + DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
> DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.${DTB_EXT} ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
> done
> @@ -81,7 +81,7 @@ pkg_postrm_kernel-devicetree () {
> for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
> symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
> DTB_EXT=${DTB##*.}
> - DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print $1}'`
> + DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
> DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
> update-alternatives --remove ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
> done
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2017-01-05 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 20:20 [PATCH] linux-dtb: strip DTB extension properly in postinst/postrm Denys Dmytriyenko
2017-01-05 20:18 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105201830.GP30576@denix.org \
--to=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.