All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <drjones@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 2/2] run_tests: allow run tests in parallel
Date: Fri, 6 Jan 2017 11:31:12 +0800	[thread overview]
Message-ID: <20170106033112.GB4135@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170105194401.GD29430@potion>

On Thu, Jan 05, 2017 at 08:44:02PM +0100, Radim Krčmář wrote:

[...]

> > Anyway, IMHO squashing you suggestion of "trap exit SIGINT" at the
> > entry of for_each_unittest() is an acceptable solution - it works in
> > all cases.
> 
> Seems like the best solution at this time ...
> We actually want to "exit 130", as it would when using normal wait does,
> and maybe it could be improved a bit by adding a wait:
> 
>   trap 'wait; exit 130' SIGINT

Sounds better, thanks!

Will repost with this one.

-- peterx

WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <drjones@redhat.com>
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v2 2/2] run_tests: allow run tests in parallel
Date: Fri, 6 Jan 2017 11:31:12 +0800	[thread overview]
Message-ID: <20170106033112.GB4135@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170105194401.GD29430@potion>

On Thu, Jan 05, 2017 at 08:44:02PM +0100, Radim Krčmář wrote:

[...]

> > Anyway, IMHO squashing you suggestion of "trap exit SIGINT" at the
> > entry of for_each_unittest() is an acceptable solution - it works in
> > all cases.
> 
> Seems like the best solution at this time ...
> We actually want to "exit 130", as it would when using normal wait does,
> and maybe it could be improved a bit by adding a wait:
> 
>   trap 'wait; exit 130' SIGINT

Sounds better, thanks!

Will repost with this one.

-- peterx

  reply	other threads:[~2017-01-06  3:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 10:10 [kvm-unit-tests PATCH v2 0/2] run_tests: support concurrent test execution Peter Xu
2017-01-03 10:10 ` [Qemu-devel] " Peter Xu
2017-01-03 10:10 ` [kvm-unit-tests PATCH v2 1/2] run_tests: put logs into per-test file Peter Xu
2017-01-03 10:10   ` [Qemu-devel] " Peter Xu
2017-01-03 10:10 ` [kvm-unit-tests PATCH v2 2/2] run_tests: allow run tests in parallel Peter Xu
2017-01-03 10:10   ` [Qemu-devel] " Peter Xu
2017-01-03 10:17   ` Peter Xu
2017-01-03 10:17     ` [Qemu-devel] " Peter Xu
2017-01-04 15:09   ` Radim Krčmář
2017-01-04 15:09     ` [Qemu-devel] " Radim Krčmář
2017-01-05  3:07     ` Peter Xu
2017-01-05  3:07       ` [Qemu-devel] " Peter Xu
2017-01-05 19:44       ` Radim Krčmář
2017-01-05 19:44         ` [Qemu-devel] " Radim Krčmář
2017-01-06  3:31         ` Peter Xu [this message]
2017-01-06  3:31           ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106033112.GB4135@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.