From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Grant Grundler <grundler@chromium.org>
Cc: Jiri Kosina <jikos@kernel.org>,
Dmitry Torokhov <dtor@chromium.org>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
Grant Grundler <grundler@google.com>
Subject: Re: [PATCH] HID: remove use of DRIVER_LICENSE
Date: Fri, 6 Jan 2017 09:06:37 +0100 [thread overview]
Message-ID: <20170106080637.GD15702@mail.corp.redhat.com> (raw)
In-Reply-To: <20170105190704.56654-1-grundler@google.com>
On Jan 05 2017 or thereabouts, Grant Grundler wrote:
> Local "#define DRIVER_LICENSE" obfuscates which license is used
> in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative
> when the string is hard coded in MODULE_LICENSE.
>
> Signed-off-by: Grant Grundler <grundler@google.com>
> ---
> Most of the kernel already uses hard coded strings.
> The few places that don't are easy to fix.
FWIW:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
next prev parent reply other threads:[~2017-01-06 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:07 [PATCH] HID: remove use of DRIVER_LICENSE Grant Grundler
2017-01-06 8:06 ` Benjamin Tissoires [this message]
2017-01-06 13:33 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106080637.GD15702@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dtor@chromium.org \
--cc=grundler@chromium.org \
--cc=grundler@google.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.