From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute Date: Fri, 6 Jan 2017 12:06:27 +0100 Message-ID: <20170106110627.GO17255@8bytes.org> References: <1483362764-11990-1-git-send-email-sricharan@codeaurora.org> <1483362764-11990-2-git-send-email-sricharan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1483362764-11990-2-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sricharan R Cc: pdaly-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jgebben-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, pratikp-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, tzeng-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Jan 02, 2017 at 06:42:36PM +0530, Sricharan R wrote: > From: Mitchel Humpherys > > Add the IOMMU_PRIV attribute, which is used to indicate privileged > mappings. > > Reviewed-by: Robin Murphy > Tested-by: Robin Murphy > Signed-off-by: Mitchel Humpherys > Acked-by: Will Deacon > --- > include/linux/iommu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 0ff5111..8c15ada 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -31,6 +31,7 @@ > #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */ > #define IOMMU_NOEXEC (1 << 3) > #define IOMMU_MMIO (1 << 4) /* e.g. things like MSI doorbells */ > +#define IOMMU_PRIV (1 << 5) /* privileged */ Since this is a new generic global flag, can you please add a more verbose comment telling what a 'privileged' mapping is about in the iommu-case? We should have a clear defined semantic for this flag or we might end up with different meanings for it with different iommu-hardware. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: joro@8bytes.org (Joerg Roedel) Date: Fri, 6 Jan 2017 12:06:27 +0100 Subject: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute In-Reply-To: <1483362764-11990-2-git-send-email-sricharan@codeaurora.org> References: <1483362764-11990-1-git-send-email-sricharan@codeaurora.org> <1483362764-11990-2-git-send-email-sricharan@codeaurora.org> Message-ID: <20170106110627.GO17255@8bytes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 02, 2017 at 06:42:36PM +0530, Sricharan R wrote: > From: Mitchel Humpherys > > Add the IOMMU_PRIV attribute, which is used to indicate privileged > mappings. > > Reviewed-by: Robin Murphy > Tested-by: Robin Murphy > Signed-off-by: Mitchel Humpherys > Acked-by: Will Deacon > --- > include/linux/iommu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 0ff5111..8c15ada 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -31,6 +31,7 @@ > #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */ > #define IOMMU_NOEXEC (1 << 3) > #define IOMMU_MMIO (1 << 4) /* e.g. things like MSI doorbells */ > +#define IOMMU_PRIV (1 << 5) /* privileged */ Since this is a new generic global flag, can you please add a more verbose comment telling what a 'privileged' mapping is about in the iommu-case? We should have a clear defined semantic for this flag or we might end up with different meanings for it with different iommu-hardware. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938309AbdAFLHN (ORCPT ); Fri, 6 Jan 2017 06:07:13 -0500 Received: from 8bytes.org ([81.169.241.247]:46445 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbdAFLG5 (ORCPT ); Fri, 6 Jan 2017 06:06:57 -0500 Date: Fri, 6 Jan 2017 12:06:27 +0100 From: Joerg Roedel To: Sricharan R Cc: jcrouse@codeaurora.org, pdaly@codeaurora.org, jgebben@codeaurora.org, linux-kernel@vger.kernel.org, pratikp@codeaurora.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, tzeng@codeaurora.org, linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, mitchelh@codeaurora.org, vinod.koul@intel.com, dan.j.williams@intel.com, linux@armlinux.org.uk Subject: Re: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute Message-ID: <20170106110627.GO17255@8bytes.org> References: <1483362764-11990-1-git-send-email-sricharan@codeaurora.org> <1483362764-11990-2-git-send-email-sricharan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483362764-11990-2-git-send-email-sricharan@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2017 at 06:42:36PM +0530, Sricharan R wrote: > From: Mitchel Humpherys > > Add the IOMMU_PRIV attribute, which is used to indicate privileged > mappings. > > Reviewed-by: Robin Murphy > Tested-by: Robin Murphy > Signed-off-by: Mitchel Humpherys > Acked-by: Will Deacon > --- > include/linux/iommu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 0ff5111..8c15ada 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -31,6 +31,7 @@ > #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */ > #define IOMMU_NOEXEC (1 << 3) > #define IOMMU_MMIO (1 << 4) /* e.g. things like MSI doorbells */ > +#define IOMMU_PRIV (1 << 5) /* privileged */ Since this is a new generic global flag, can you please add a more verbose comment telling what a 'privileged' mapping is about in the iommu-case? We should have a clear defined semantic for this flag or we might end up with different meanings for it with different iommu-hardware. Joerg