All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Laurent Pinchart"
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2] ARM: omap3: beagleboard-xm: dt: Add ethernet to the device tree
Date: Fri, 6 Jan 2017 08:49:05 -0800	[thread overview]
Message-ID: <20170106164904.GG2630@atomide.com> (raw)
In-Reply-To: <CAL_JsqKQLd2SFNVKwZDPTKL-spWknEe5aFDT5RZoCnV1qOP=4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

* Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [170105 10:51]:
> On Thu, Jan 5, 2017 at 10:48 AM, Laurent Pinchart
> <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote:
> > Hello,
> >
> > On Thursday 05 Jan 2017 08:39:29 Tony Lindgren wrote:
> >> * Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [170105 08:28]:
> >> > On Fri, Dec 2, 2016 at 3:11 PM, Laurent Pinchart wrote:
> >> >> The Beagleboard-xM has a LAN9514 USB hub and ethernet controller,
> >> >> connected to port 2 of the OMAP EHCI controller. The board however has
> >> >> no EEPROM to store the ethernet MAC address, which is programmed by the
> >> >> boot loader.
> >> >>
> >> >> To allow Linux to use the same MAC address as the boot loader (or for
> >> >> that matter any fixed MAC address), we need a node in the device tree
> >> >> for the ethernet controller that the boot loader can update at runtime
> >> >> with a local-mac-address property. Add it, along with an alias for the
> >> >> ethernet controller to let the boot loader locate it easily.
> >> >>
> >> >> Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> >> >> ---
> >> >> Changes since v1:
> >> >>
> >> >> - Renamed usb2 DT node to hub
> >> >> ---
> >> >>
> >> >>  arch/arm/boot/dts/omap3-beagle-xm.dts | 16 ++++++++++++++++
> >> >>  1 file changed, 16 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts
> >> >> b/arch/arm/boot/dts/omap3-beagle-xm.dts index
> >> >> 85e297ed0ea1..673cee2234b2 100644
> >> >> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> >> >> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> >> >> @@ -27,6 +27,7 @@
> >> >>         aliases {
> >> >>                 display0 = &dvi0;
> >> >>                 display1 = &tv0;
> >> >> +               ethernet = &ethernet;
> >> >
> >> > Sorry, just noticed this, but this should be dropped. It's not used
> >> > nor do we want an alias here.
> >>
> >> OK, will update locally as I have not pushed out yet.
> >
> > The ethernet alias is used by U-Boot to locate the ethernet controller and
> > update the MAC address.
> 
> Okay. Though with only only one, I don't see why that is hard to find.
> Anyway, this is the least of u-boot's DT abuses.

Applying Laurent's original patch then into omap-for-v4.11/dt.

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-01-06 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 21:11 [PATCH v2] ARM: omap3: beagleboard-xm: dt: Add ethernet to the device tree Laurent Pinchart
     [not found] ` <1480713097-5931-1-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2017-01-05 16:19   ` Tony Lindgren
2017-01-05 16:27   ` Rob Herring
     [not found]     ` <CAL_Jsq+M7RWiytEA7zPZvR+7CK37WCxN5ZBOQkpjdswjLHL4fA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-05 16:39       ` Tony Lindgren
     [not found]         ` <20170105163928.GD4310-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-05 16:48           ` Laurent Pinchart
2017-01-05 16:51             ` Tony Lindgren
2017-01-05 18:50             ` Rob Herring
     [not found]               ` <CAL_JsqKQLd2SFNVKwZDPTKL-spWknEe5aFDT5RZoCnV1qOP=4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-06 16:49                 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106164904.GG2630@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.