Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Jan 06, 2017 at 09:02:42AM -0800, no-reply@patchew.org wrote:
> Hi,
> 
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce it

[snip]

> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_update’:
> /tmp/qemu-test/src/hw/char/pl011.c:62: warning: implicit declaration of function ‘trace_pl011_irq_state’
> /tmp/qemu-test/src/hw/char/pl011.c:62: warning: nested extern declaration of ‘trace_pl011_irq_state’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_read’:
> /tmp/qemu-test/src/hw/char/pl011.c:87: warning: implicit declaration of function ‘trace_pl011_read_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:87: warning: nested extern declaration of ‘trace_pl011_read_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:139: warning: implicit declaration of function ‘trace_pl011_read’
> /tmp/qemu-test/src/hw/char/pl011.c:139: warning: nested extern declaration of ‘trace_pl011_read’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_write’:
> /tmp/qemu-test/src/hw/char/pl011.c:163: warning: implicit declaration of function ‘trace_pl011_write’
> /tmp/qemu-test/src/hw/char/pl011.c:163: warning: nested extern declaration of ‘trace_pl011_write’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_can_receive’:
> /tmp/qemu-test/src/hw/char/pl011.c:237: warning: implicit declaration of function ‘trace_pl011_can_receive’
> /tmp/qemu-test/src/hw/char/pl011.c:237: warning: nested extern declaration of ‘trace_pl011_can_receive’
> /tmp/qemu-test/src/hw/char/pl011.c: In function ‘pl011_put_fifo’:
> /tmp/qemu-test/src/hw/char/pl011.c:252: warning: implicit declaration of function ‘trace_pl011_put_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:252: warning: nested extern declaration of ‘trace_pl011_put_fifo’
> /tmp/qemu-test/src/hw/char/pl011.c:254: warning: implicit declaration of function ‘trace_pl011_put_fifo_full’
> /tmp/qemu-test/src/hw/char/pl011.c:254: warning: nested extern declaration of ‘trace_pl011_put_fifo_full’

Sigh, include search path ordering is different when doing in-tree vs
out of tree builds.

When in-tree, the headers in the hw/char sub-dir are found *before*
the top level source dir.

When out of tree, the headers hw/char *build* dir are found *after*
the top level source dir.

Will have to investigate how we can fix the include ordering.

This is also a sign that travis.yml should do at least one of its
builds  with srcdir != build dir

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|