Re: Bug in recent pad patch (96eb371b816c)

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Fri, Jan 06, 2017 at 12:06:39PM -0600, Cameron Gutman wrote:
> It looks like the recent commit in master
> 
> 	96eb371b816c ("Input: xpad - correctly sort vendor id's")
> 
> adds a duplicate entry for XPAD_XBOXONE_VENDOR(0x24c6).
> 
> You may want to amend that with the following:

Thanks, I amended the offending commit.

> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index ceb6a58..c06b717 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -325,7 +325,6 @@ static struct usb_device_id xpad_table[] = {
>  	XPAD_XBOX360_VENDOR(0x12ab),		/* X-Box 360 dance pads */
>  	XPAD_XBOX360_VENDOR(0x1430),		/* RedOctane X-Box 360 controllers */
>  	XPAD_XBOX360_VENDOR(0x146b),		/* BigBen Interactive Controllers */
> -	XPAD_XBOXONE_VENDOR(0x24c6),		/* PowerA Controllers */
>  	XPAD_XBOX360_VENDOR(0x1532),		/* Razer Sabertooth */
>  	XPAD_XBOX360_VENDOR(0x15e4),		/* Numark X-Box 360 controllers */
>  	XPAD_XBOX360_VENDOR(0x162e),		/* Joytech X-Box 360 controllers */
> 

-- 
Dmitry