All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "agk@redhat.com" <agk@redhat.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"shli@kernel.org" <shli@kernel.org>,
	"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/md/dm-mpath.c:478: suspicious code ?
Date: Fri, 6 Jan 2017 15:08:55 -0500	[thread overview]
Message-ID: <20170106200855.GA15627@redhat.com> (raw)
In-Reply-To: <VI1PR08MB10227DFB2600B24201D3209D9C630@VI1PR08MB1022.eurprd08.prod.outlook.com>

On Fri, Jan 06 2017 at 12:52pm -0500,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> drivers/md/dm-mpath.c:478:19: warning: decrement of a boolean expression [-Wbool-operation]
> 
> Source code is
> 
>    } while (bypassed--);
> 
> Suggest code rework. Maybe a boolean / int type mixup ?

Yeah, should be cleaned up.

Thanks for reporting this.

      reply	other threads:[~2017-01-06 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 17:52 drivers/md/dm-mpath.c:478: suspicious code ? David Binderman
2017-01-06 20:08 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106200855.GA15627@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dcb314@hotmail.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.