From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3 Date: Sat, 7 Jan 2017 06:40:13 +0000 Message-ID: <20170107064012.GI1555@ZenIV.linux.org.uk> References: <87d1fzzbc2.fsf@xmission.com> <20170107062952.GH1555@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170107062952.GH1555-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Linus Torvalds , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote: > On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote: > > > Eric W. Biederman (3): > > mnt: Protect the mountpoint hashtable with mount_lock > ACK > > > mnt: Tuck mounts under others instead of creating shadow/side mounts. > > NAK; you have reintroduced put_mountpoint() outside of mount lock in there > and you've got seriously confused umount side of the things. PS: details are in my reply (admittedly, sent only ~20 minutes before your pull request) to your patch. Check Message-ID <20170107050644.GA12074-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> My apologies for not getting to it yesterday (the patch was posted a couple of days ago, AFAICS) - I'd been off-net since Wednesday, just got back ;-/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:35158 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967877AbdAGGkR (ORCPT ); Sat, 7 Jan 2017 01:40:17 -0500 Date: Sat, 7 Jan 2017 06:40:13 +0000 From: Al Viro To: "Eric W. Biederman" Cc: Linus Torvalds , Linux Containers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3 Message-ID: <20170107064012.GI1555@ZenIV.linux.org.uk> References: <87d1fzzbc2.fsf@xmission.com> <20170107062952.GH1555@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170107062952.GH1555@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote: > On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote: > > > Eric W. Biederman (3): > > mnt: Protect the mountpoint hashtable with mount_lock > ACK > > > mnt: Tuck mounts under others instead of creating shadow/side mounts. > > NAK; you have reintroduced put_mountpoint() outside of mount lock in there > and you've got seriously confused umount side of the things. PS: details are in my reply (admittedly, sent only ~20 minutes before your pull request) to your patch. Check Message-ID <20170107050644.GA12074@ZenIV.linux.org.uk> My apologies for not getting to it yesterday (the patch was posted a couple of days ago, AFAICS) - I'd been off-net since Wednesday, just got back ;-/