From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sumit negi <er20snegi@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Aniket Sharma <badbuddha91@gmail.com>,
Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue
Date: Sat, 7 Jan 2017 14:08:53 +0100 [thread overview]
Message-ID: <20170107130852.GA27944@kroah.com> (raw)
In-Reply-To: <20170107101805.3518-1-er20snegi@gmail.com>
On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote:
> Fixed a camel style issue.
Really? Look at what you changed:
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
mA means something, correct? Why did you change that?
checkpatch is a _hint_, you still always have to use your brain. Don't
blindly make changes that make no sense, like this one :(
sorry,
greg k-h
prev parent reply other threads:[~2017-01-07 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 10:18 [PATCH] Stagging :Comedi :Fixed Camel Case Style issue sumit negi
2017-01-07 13:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107130852.GA27944@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=badbuddha91@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=er20snegi@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.