From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Sun, 8 Jan 2017 02:13:28 -0800 Subject: [PATCH] nvme: use __iowrite64_copy for SQs in the CMB In-Reply-To: References: <20161121091411.GA10123@infradead.org> <20161221102237.GA24532@infradead.org> Message-ID: <20170108101328.GF25268@infradead.org> On Wed, Jan 04, 2017@09:22:34AM +0200, Saar Gross wrote: > As already mentioned: the current implementation uses memcpy() which > is generic in nature, whereas the new implementation uses explicit > 64-bit writes when possible. > What else are you looking for? Any explanation of why this would benefit the driver in practive. You've now explained the mechanics of your change in detail, but still haven't shown in numbers or bugs fixed. Note that we currently don't use 64-bit MMIO writes in the NVMe driver at all, as we work around buggy Apple controllers. This would be the first one, and while I'm not against it at all, I'd rather have a good reason to make the change instead of just having a drive-by patch in the tree.