From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, eguan@redhat.com,
darrick.wong@oracle.com
Subject: Re: [PATCH 2/5] xfs: fix the alignment fallback in xfs_bmap_btalloc
Date: Sun, 8 Jan 2017 11:31:34 +0100 [thread overview]
Message-ID: <20170108103134.GB26451@lst.de> (raw)
In-Reply-To: <20170104143405.GB41989@bfoster.bfoster>
On Wed, Jan 04, 2017 at 09:34:05AM -0500, Brian Foster wrote:
> Ok, but we have the following near the top of xfs_alloc_vextent():
>
> if (args->alignment == 0)
> args->alignment = 1;
>
> ... so I'm not sure the commit log description is accurate. That aside:
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Well, in that case we might not actually need it. This was just a
a drive-by patch from investigating what the alignmnet - 1 mean in
the allocator.
Either way this could be cleaned up, but probably shouldn't be in
a minimal bugfix series.
next prev parent reply other threads:[~2017-01-08 10:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 20:00 minleft fixes V2 Christoph Hellwig
2016-12-22 20:00 ` [PATCH 1/5] xfs: bump up reserved blocks in xfs_alloc_set_aside Christoph Hellwig
2017-01-04 14:33 ` Brian Foster
2017-01-08 10:30 ` Christoph Hellwig
2017-01-08 16:07 ` Brian Foster
2016-12-22 20:00 ` [PATCH 2/5] xfs: fix the alignment fallback in xfs_bmap_btalloc Christoph Hellwig
2017-01-04 14:34 ` Brian Foster
2017-01-08 10:31 ` Christoph Hellwig [this message]
2017-01-08 16:08 ` Brian Foster
2016-12-22 20:00 ` [PATCH 3/5] xfs: fix bogus minleft manipulations Christoph Hellwig
2017-01-04 18:19 ` Brian Foster
2017-01-08 10:36 ` Christoph Hellwig
2017-01-08 16:09 ` Brian Foster
2017-01-09 17:56 ` Christoph Hellwig
2016-12-22 20:00 ` [PATCH 4/5] xfs: adjust allocation length in xfs_alloc_space_available Christoph Hellwig
2017-01-04 18:19 ` Brian Foster
2016-12-22 20:00 ` [PATCH 5/5] xfs: don't rely on ->total " Christoph Hellwig
2017-01-04 18:19 ` Brian Foster
2017-01-05 1:21 ` minleft fixes V2 Eryu Guan
2017-01-05 2:01 ` Darrick J. Wong
2017-01-08 10:36 ` Christoph Hellwig
2017-01-08 16:10 ` Brian Foster
2017-01-08 18:10 ` Darrick J. Wong
2017-01-09 15:22 ` Brian Foster
2017-01-09 15:34 ` Christoph Hellwig
2017-01-09 15:43 ` Brian Foster
2017-01-10 4:23 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108103134.GB26451@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.