From: Jiri Pirko <jiri@resnulli.us>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Roi Dayan <roid@mellanox.com>
Subject: Re: [PATCH net-next 4/7] devlink: Add E-Switch inline mode control
Date: Sun, 8 Jan 2017 11:54:14 +0100 [thread overview]
Message-ID: <20170108105414.GC1971@nanopsycho> (raw)
In-Reply-To: <90f3f9f5-beec-be9d-7c92-e6f41f3fd55e@mellanox.com>
Sun, Jan 08, 2017 at 11:49:20AM CET, ogerlitz@mellanox.com wrote:
>On 1/8/2017 12:29 PM, Jiri Pirko wrote:
>> Mon, Nov 21, 2016 at 02:05:58PM CET, saeedm@mellanox.com wrote:
>> > From: Roi Dayan <roid@mellanox.com>
>> >
>> > Some HWs need the VF driver to put part of the packet headers on the
>> > TX descriptor so the e-switch can do proper matching and steering.
>> Could you please elaborate a bit about possible use-cases for different
>> modes? Thanks.
>
>As written in the change log, some HW models have this requirement that the
>header set you want eswitch matching on (e.g L2/L3) is present as MD on the
>xmit DMA descriptor.
>
>To address these requirements, following the admin devlink directive the FW
>advertizes that
>to the VF, they are doing so in their xmit logic and the host driver enforces
>that the VF has the proper inline mode before we are willing to offload
>eswitch matching rules. If the VF doesn't obey to the requirement the packets
>are dropped by HW.
Okay, makes sense. Do you expect this will ever have to be needed
per-vf? In general, not only for mlx* drivers. I believe that this is
an e-switch requirement so it should be same for all connected VFs,
right?
Thanks!
next prev parent reply other threads:[~2017-01-08 10:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 13:05 [PATCH net-next 0/7] Mellanox 100G mlx5 SRIOV switchdev update Saeed Mahameed
2016-11-21 13:05 ` [PATCH net-next 1/7] net: Add net-device param to the get offloaded stats ndo Saeed Mahameed
2016-11-21 14:49 ` kbuild test robot
2016-11-21 13:05 ` [PATCH net-next 2/7] net/mlx5e: Support HW (offloaded) and SW counters for SRIOV switchdev mode Saeed Mahameed
2016-11-21 13:05 ` [PATCH net-next 3/7] net/mlx5e: Support VF vport link state control " Saeed Mahameed
2016-11-21 13:05 ` [PATCH net-next 4/7] devlink: Add E-Switch inline mode control Saeed Mahameed
2017-01-08 10:29 ` Jiri Pirko
2017-01-08 10:49 ` Or Gerlitz
2017-01-08 10:54 ` Jiri Pirko [this message]
2017-01-08 11:10 ` Or Gerlitz
2016-11-21 13:05 ` [PATCH net-next 5/7] net/mlx5: Enable to query min inline for a specific vport Saeed Mahameed
2016-11-21 13:06 ` [PATCH net-next 6/7] net/mlx5: E-Switch, Add control for inline mode Saeed Mahameed
2017-01-08 9:56 ` Jiri Pirko
2017-01-08 15:58 ` Saeed Mahameed
2016-11-21 13:06 ` [PATCH net-next 7/7] net/mlx5e: Enforce min inline mode when offloading flows Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108105414.GC1971@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roid@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.