From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162013AbdAHLcU (ORCPT ); Sun, 8 Jan 2017 06:32:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933549AbdAHLbc (ORCPT ); Sun, 8 Jan 2017 06:31:32 -0500 Date: Sun, 8 Jan 2017 12:31:52 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Alan Stern , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH] usb: storage: ene_ub6250: remove unused variable Message-ID: <20170108113152.GA15608@kroah.com> References: <1482100471-2471-1-git-send-email-sudipm.mukherjee@gmail.com> <20170105183631.GA23141@kroah.com> <58717993.3010906@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58717993.3010906@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote: > On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote: > > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote: > > > The variable Newblk was only being assigned some value but was never > > > used after that. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > drivers/usb/storage/ene_ub6250.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > from and signed-off-by does not match :( > > > > Same with your other usb patch... > > > > I can add the From: tag in the patch. But this is from the last time we had > this same conversation. > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html I can't remember an email thread from last week, or even yesterday, let alone from almost a year ago. I suggest you fix your email server so we don't have the same conversation next week, or use the From: line in the patch which is what I am expecting people to do for crappy email servers like this. :) thanks, greg k-h