All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Create libdir directory before installing libperf-jvmti.so
Date: Sun, 8 Jan 2017 15:24:52 +0100	[thread overview]
Message-ID: <20170108142452.GA17926@krava> (raw)
In-Reply-To: <1483741088-13543-1-git-send-email-labbott@redhat.com>

On Fri, Jan 06, 2017 at 02:18:08PM -0800, Laura Abbott wrote:
> The install command for libperf-jvmti.so does not check if libdir exists
> before installing. This means that when the install command is run:
> 
> install libperf-jvmti.so '/tmp/test_root/usr/lib64';
> 
> libperf-jvmti.so will get installed to /usr/lib64 as a file and break further
> installation. Fix this by ensuring the directory gets created first.
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=1410296
> 
> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> For full disclosure, Fedora is setting NO_JVMTI but this should still be fixed
> to allow it to be turned on in the future.

Acked-by: Jiri Olsa <jolsa@redhat.com>

I have patches for fedora to install that, looks like you guys
are not planning to enable it, so I'll post it soon ;-)

thanks,
jirka

  reply	other threads:[~2017-01-08 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 22:18 [PATCH] perf tools: Create libdir directory before installing libperf-jvmti.so Laura Abbott
2017-01-08 14:24 ` Jiri Olsa [this message]
2017-01-12  8:28 ` [tip:perf/core] perf jvmti: " tip-bot for Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170108142452.GA17926@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.