From: Shawn Guo <shawnguo@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] Add CRTC helper drm_crtc_from_index()
Date: Mon, 9 Jan 2017 17:03:35 +0800 [thread overview]
Message-ID: <20170109090333.GM20956@dragon> (raw)
In-Reply-To: <20161230111643.GD2667@dvetter-linux.ger.corp.intel.com>
On Fri, Dec 30, 2016 at 12:16:43PM +0100, Daniel Vetter wrote:
> Entire series applied. I suspect that there's more drivers open-coding
> something like this in their vblank code, might be worth it to grep for
> them all and do a quick audit.
I did a round of audit on all drivers vblank code, and found there are
basically 3 categories:
1. Drivers that only support one CRTC. In this case, the 'pipe' is not
used at all in vblank code. So we need to do thing about them.
Examples: arm, atmel-hlcdc, mxsfb, etc.
2. Drivers that maintain CRTC pointers and number in the private
structure. And the fields are used in somewhere else beside vblank
code. The cleanup will need a bit surgery on the driver code. I would
leave them out for driver owners/maintainers. Examples: armada, msm,
sti, etc.
3. Drivers that can use the helper for benefit, including exynos, kirin,
mediatek, nouveau, tegra and vc4. I have already prepared a series for
these drivers, and will send it out for review shortly.
Shawn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-09 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 12:41 [PATCH 0/3] Add CRTC helper drm_crtc_from_index() Shawn Guo
2016-12-29 12:41 ` [PATCH 1/3] drm: add crtc " Shawn Guo
2016-12-30 11:14 ` Daniel Vetter
2016-12-29 12:41 ` [PATCH 2/3] drm: zte: use " Shawn Guo
2016-12-29 12:41 ` [PATCH 3/3] drm: rockchip: " Shawn Guo
2016-12-30 11:16 ` [PATCH 0/3] Add CRTC " Daniel Vetter
2017-01-09 9:03 ` Shawn Guo [this message]
2017-01-09 9:58 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109090333.GM20956@dragon \
--to=shawnguo@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.