From: Christoph Hellwig <hch@infradead.org>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't print warnings when xfs_log_force fails
Date: Mon, 9 Jan 2017 03:08:03 -0800 [thread overview]
Message-ID: <20170109110803.GA27554@infradead.org> (raw)
In-Reply-To: <1482999799-11776-2-git-send-email-hch@lst.de>
On Thu, Dec 29, 2016 at 09:23:19AM +0100, Christoph Hellwig wrote:
> There are only two reasons for xfs_log_force / xfs_log_force_lsn to fail:
> one is an I/O error, for which xlog_bdstrat already logs a warning, and
> the second is an already shutdown log due to a previous I/O errors. In
> the latter case we'll already have a previous indication for the actual
> error, but the large stream of misleading warnings from xfs_log_force
> will probably scroll it out of the message buffer.
>
> Simply removing the warnings thus makes the XFS log reporting significantly
> better.
Darrick,
any opinion on this one? I was hoping to sneak it into 4.10-rc still..
next prev parent reply other threads:[~2017-01-09 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 8:23 make log force warnings less annoying Christoph Hellwig
2016-12-29 8:23 ` [PATCH] xfs: don't print warnings when xfs_log_force fails Christoph Hellwig
2016-12-29 14:42 ` Alex Elder
2016-12-29 18:09 ` Christoph Hellwig
2016-12-29 19:00 ` Alex Elder
2017-01-02 9:28 ` Carlos Maiolino
2017-01-09 11:08 ` Christoph Hellwig [this message]
2017-01-09 21:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109110803.GA27554@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.