All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <eguan@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: fix error redirection in generic/256
Date: Mon, 9 Jan 2017 05:40:08 -0800	[thread overview]
Message-ID: <20170109134008.GC19577@infradead.org> (raw)
In-Reply-To: <20161112183943.GK27776@eguan.usersys.redhat.com>

On Sun, Nov 13, 2016 at 02:39:43AM +0800, Eryu Guan wrote:
> On Sat, Nov 12, 2016 at 08:47:20AM -0800, Christoph Hellwig wrote:
> > Not sure if my shell is the problem here, but I need this explicit
> > redirection to ignore the error output from mkdir and xfs_io, otherwise
> > the test fails due to the error messages from these commands.
> 
> That's weird, from bash manpage, "&>" should be equivalent to "> ... 2>&1"
> 
> There're many other tests use "&>" as well, do you see such failures
> from other tests, such as generic/347?

No.  But 256 keeps on failing for me without this.  Given that it's
just a slightly more verbose syntax is there any reason not to just
apply this patch for now?

  parent reply	other threads:[~2017-01-09 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-12 16:47 [PATCH] fstests: fix error redirection in generic/256 Christoph Hellwig
2016-11-12 18:39 ` Eryu Guan
2016-11-13 12:11   ` Christoph Hellwig
2017-01-09 13:40   ` Christoph Hellwig [this message]
2017-01-10  3:46     ` Eryu Guan
2017-01-10  3:57       ` Eryu Guan
2017-01-10  4:27     ` Eryu Guan
2017-01-10  6:28       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109134008.GC19577@infradead.org \
    --to=hch@infradead.org \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.