From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Tue, 10 Jan 2017 09:17:56 +0800 Subject: [PATCH v4 3/3] drm: zte: add overlay plane support In-Reply-To: References: <1483972544-12731-1-git-send-email-shawnguo@kernel.org> <1483972544-12731-4-git-send-email-shawnguo@kernel.org> Message-ID: <20170110011754.GO20956@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sean, On Mon, Jan 09, 2017 at 11:27:44AM -0500, Sean Paul wrote: > > +static inline void zx_osd_int_update(struct zx_crtc *zcrtc) > > +{ > > + struct zx_vou_hw *vou = zcrtc->vou; > > + int i; > > + > > + vou_chn_set_update(zcrtc); > > + zx_plane_set_update(zcrtc->primary); > > + > > + for (i = 0; i < VL_NUM; i++) { > > + struct drm_plane *overlay = vou->overlays[i]; > > + > > + if (overlay) > > + zx_plane_set_update(overlay); > > + } > > Hi Shawn, > Thanks so much for revving this patch, it's looking really good. I > just have one (1.5, really) suggestion. > > I don't think we need to keep vou->overlays around. You should be able > to loop through all the planes registered with drm core and use > crtc->state->plane_mask to determine which are active for a given crtc > (this would also encapsulate the zcrtc->primary update above). > > I think you can also use if (plane->state->crtc) as your > enable/disable check in zx_plane_set_update() and eliminate the new > enabled flag. Great. Since I'm still quite new to DRM subsystem, such core infrastructural usage guide are really helpful for me. I tested the changes as you suggested, and they worked just fine. So happy to see my code gets cleaned up further. > I fully realize this was my suggestion, and I apologize > for the churn. I'll try not to do reviews past midnight again :-) I'm so grateful to you for helping review my code, especially in midnight time :) Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v4 3/3] drm: zte: add overlay plane support Date: Tue, 10 Jan 2017 09:17:56 +0800 Message-ID: <20170110011754.GO20956@dragon> References: <1483972544-12731-1-git-send-email-shawnguo@kernel.org> <1483972544-12731-4-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AE916E29C for ; Tue, 10 Jan 2017 01:18:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Daniel Vetter , Baoyou Xie , dri-devel , Linux ARM Kernel , Jun Nie List-Id: dri-devel@lists.freedesktop.org SGkgU2VhbiwKCk9uIE1vbiwgSmFuIDA5LCAyMDE3IGF0IDExOjI3OjQ0QU0gLTA1MDAsIFNlYW4g UGF1bCB3cm90ZToKPiA+ICtzdGF0aWMgaW5saW5lIHZvaWQgenhfb3NkX2ludF91cGRhdGUoc3Ry dWN0IHp4X2NydGMgKnpjcnRjKQo+ID4gK3sKPiA+ICsgICAgICAgc3RydWN0IHp4X3ZvdV9odyAq dm91ID0gemNydGMtPnZvdTsKPiA+ICsgICAgICAgaW50IGk7Cj4gPiArCj4gPiArICAgICAgIHZv dV9jaG5fc2V0X3VwZGF0ZSh6Y3J0Yyk7Cj4gPiArICAgICAgIHp4X3BsYW5lX3NldF91cGRhdGUo emNydGMtPnByaW1hcnkpOwo+ID4gKwo+ID4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgVkxfTlVN OyBpKyspIHsKPiA+ICsgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lICpvdmVybGF5ID0g dm91LT5vdmVybGF5c1tpXTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBpZiAob3ZlcmxheSkK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHp4X3BsYW5lX3NldF91cGRhdGUob3ZlcmxheSk7 Cj4gPiArICAgICAgIH0KPiAKPiBIaSBTaGF3biwKPiBUaGFua3Mgc28gbXVjaCBmb3IgcmV2dmlu ZyB0aGlzIHBhdGNoLCBpdCdzIGxvb2tpbmcgcmVhbGx5IGdvb2QuIEkKPiBqdXN0IGhhdmUgb25l ICgxLjUsIHJlYWxseSkgc3VnZ2VzdGlvbi4KPiAKPiBJIGRvbid0IHRoaW5rIHdlIG5lZWQgdG8g a2VlcCB2b3UtPm92ZXJsYXlzIGFyb3VuZC4gWW91IHNob3VsZCBiZSBhYmxlCj4gdG8gbG9vcCB0 aHJvdWdoIGFsbCB0aGUgcGxhbmVzIHJlZ2lzdGVyZWQgd2l0aCBkcm0gY29yZSBhbmQgdXNlCj4g Y3J0Yy0+c3RhdGUtPnBsYW5lX21hc2sgdG8gZGV0ZXJtaW5lIHdoaWNoIGFyZSBhY3RpdmUgZm9y IGEgZ2l2ZW4gY3J0Ywo+ICh0aGlzIHdvdWxkIGFsc28gZW5jYXBzdWxhdGUgdGhlIHpjcnRjLT5w cmltYXJ5IHVwZGF0ZSBhYm92ZSkuCj4gCj4gSSB0aGluayB5b3UgY2FuIGFsc28gdXNlIGlmIChw bGFuZS0+c3RhdGUtPmNydGMpIGFzIHlvdXIKPiBlbmFibGUvZGlzYWJsZSBjaGVjayBpbiB6eF9w bGFuZV9zZXRfdXBkYXRlKCkgYW5kIGVsaW1pbmF0ZSB0aGUgbmV3Cj4gZW5hYmxlZCBmbGFnLgoK R3JlYXQuICBTaW5jZSBJJ20gc3RpbGwgcXVpdGUgbmV3IHRvIERSTSBzdWJzeXN0ZW0sIHN1Y2gg Y29yZQppbmZyYXN0cnVjdHVyYWwgdXNhZ2UgZ3VpZGUgYXJlIHJlYWxseSBoZWxwZnVsIGZvciBt ZS4gIEkgdGVzdGVkIHRoZQpjaGFuZ2VzIGFzIHlvdSBzdWdnZXN0ZWQsIGFuZCB0aGV5IHdvcmtl ZCBqdXN0IGZpbmUuICBTbyBoYXBweSB0byBzZWUgbXkKY29kZSBnZXRzIGNsZWFuZWQgdXAgZnVy dGhlci4KCj4gSSBmdWxseSByZWFsaXplIHRoaXMgd2FzIG15IHN1Z2dlc3Rpb24sIGFuZCBJIGFw b2xvZ2l6ZQo+IGZvciB0aGUgY2h1cm4uIEknbGwgdHJ5IG5vdCB0byBkbyByZXZpZXdzIHBhc3Qg bWlkbmlnaHQgYWdhaW4gOi0pCgpJJ20gc28gZ3JhdGVmdWwgdG8geW91IGZvciBoZWxwaW5nIHJl dmlldyBteSBjb2RlLCBlc3BlY2lhbGx5IGluCm1pZG5pZ2h0IHRpbWUgOikKClNoYXduCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=