From: Johan Hovold <johan@kernel.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: Johan Hovold <johan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks
Date: Tue, 10 Jan 2017 09:43:27 +0100 [thread overview]
Message-ID: <20170110084327.GA3501@localhost> (raw)
In-Reply-To: <650c00e9-cf02-1764-5065-86f6c06817f3@codeaurora.org>
On Mon, Jan 09, 2017 at 01:49:53PM -0600, Timur Tabi wrote:
> On 11/24/2016 12:21 PM, Johan Hovold wrote:
> > + if (!has_acpi_companion(&pdev->dev))
> > + put_device(&adpt->phydev->mdio.dev);
>
> I was wondering if, instead of calling put_device() only on non-ACPI systems,
> would it be better if on an ACPI system I called get_device() manually? That
> is, some thing like this:
>
> int emac_phy_config(struct platform_device *pdev, struct emac_adapter *adpt)
> {
> ...
> if (has_acpi_companion(&pdev->dev)) {
> ...
> get_device(&mii_bus->dev);
> } else {
> ...
Yeah, that's better.
Thanks,
Johan
next prev parent reply other threads:[~2017-01-10 8:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 18:21 [PATCH net v2 0/5] net: fix phydev reference leaks Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 1/5] net: dsa: fix fixed-link-phy device leaks Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 2/5] net: bcmgenet: fix phydev reference leak Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 3/5] net: fsl/fman: " Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev " Johan Hovold
2016-11-25 10:54 ` Madalin-Cristian Bucur
2016-11-24 18:21 ` [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks Johan Hovold
2016-11-24 18:55 ` Timur Tabi
2017-01-09 19:49 ` Timur Tabi
2017-01-10 8:43 ` Johan Hovold [this message]
2016-11-28 1:02 ` [PATCH net v2 0/5] net: fix phydev reference leaks David Miller
2016-11-28 2:11 ` Timur Tabi
2016-11-28 4:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110084327.GA3501@localhost \
--to=johan@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.