From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 8/8] eal: VMBUS infrastructure
Date: Tue, 10 Jan 2017 10:05:02 -0800
Message-ID: <20170110100502.5b55059b@xeon-e3>
References: <20170107181756.1944-1-sthemmin@microsoft.com>
 <20170107181756.1944-9-sthemmin@microsoft.com>
 <CALe+Z000WmS4WeL315otctGkYayPqspEB20o+RTxzgA8ieS8_g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Jan Blunck <jblunck@infradead.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 731A35320
 for <dev@dpdk.org>; Tue, 10 Jan 2017 19:05:09 +0100 (CET)
Received: by mail-pf0-f174.google.com with SMTP id f144so41117374pfa.2
 for <dev@dpdk.org>; Tue, 10 Jan 2017 10:05:09 -0800 (PST)
In-Reply-To: <CALe+Z000WmS4WeL315otctGkYayPqspEB20o+RTxzgA8ieS8_g@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 10 Jan 2017 18:27:31 +0100
Jan Blunck <jblunck@infradead.org> wrote:

> > +#ifdef RTE_LIBRTE_HV_PMD
> > +/**
> > + * @internal
> > + * Wrapper for use by vmbus drivers as a .probe function to attach to a ethdev
> > + * interface.
> > + */
> > +int rte_eth_dev_vmbus_probe(struct rte_vmbus_driver *vmbus_drv,
> > +                         struct rte_vmbus_device *vmbus_dev);
> > +
> > +/**
> > + * @internal
> > + * Wrapper for use by vmbus drivers as a .remove function to detach a ethdev
> > + * interface.
> > + */
> > +int rte_eth_dev_vmbus_remove(struct rte_vmbus_device *vmbus_dev);
> > +#endif  
> 
> I don't think that replicating the PCI probe/remove wrappers is the
> right thing to do. To me it looks like this should move into the
> rte_vmbus_driver's probe function instead. That way the ethdev header
> can decoupled from the low-level device implementations.

With a real bus model. There would be registration of busses. And the probe would
be:
   foreach bus
       foreach device on bus
...