diff for duplicates of <20170110130300.167d215b@endymion> diff --git a/a/1.txt b/N1/1.txt index 0294c5a..9ab76f5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ -On Mon, 9 Jan 2017 21:08:50 +0100, Andreas F=C3=A4rber wrote: +On Mon, 9 Jan 2017 21:08:50 +0100, Andreas Färber wrote: > Hi Jean, ->=20 +> > Am 09.01.2017 um 11:36 schrieb Jean Delvare: > > If I say "no" to "Clock driver for Mediatek MT2701", I don't want to > > be asked individually about each sub-driver. No means no. -> >=20 +> > > > Additionally, this driver shouldn't be proposed at all on non-mediatek > > builds, unless build-testing. -> >=20 +> > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > Fixes: e9862118272a ("clk: mediatek: Add MT2701 clock support") > > Cc: Shunli Wang <shunli.wang@mediatek.com> @@ -20,7 +20,7 @@ On Mon, 9 Jan 2017 21:08:50 +0100, Andreas F=C3=A4rber wrote: > [...] > > As another side note, I wonder why so many clock drivers have > > "COMMON" in their symbol names. Looks wrong to me. ->=20 +> > It refers to the Common Clock Framework: > https://www.kernel.org/doc/Documentation/clk.txt @@ -28,18 +28,16 @@ OK, thanks for the explanation. Still seems overkill to me to prefix everything with COMMON_CLK when the drivers live under drivers/clk, but oh well :-) -> > --- linux-4.10-rc2.orig/drivers/clk/mediatek/Kconfig 2017-01-01 23:31:5= -3.000000000 +0100 -> > +++ linux-4.10-rc2/drivers/clk/mediatek/Kconfig 2017-01-09 11:17:37.542= -344083 +0100 +> > --- linux-4.10-rc2.orig/drivers/clk/mediatek/Kconfig 2017-01-01 23:31:53.000000000 +0100 +> > +++ linux-4.10-rc2/drivers/clk/mediatek/Kconfig 2017-01-09 11:17:37.542344083 +0100 > > @@ -8,6 +8,7 @@ config COMMON_CLK_MEDIATEK -> > =20 +> > > > config COMMON_CLK_MT2701 > > bool "Clock driver for Mediatek MT2701" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > select COMMON_CLK_MEDIATEK > > default ARCH_MEDIATEK ->=20 +> > Should the default then become y for simplicity? I left it as is as it is the same already done in other drivers in the @@ -47,11 +45,10 @@ same directory. I agree "default y" would do the same in practice. > Another aspect here is that this is a 32-bit SoC but it propagates into > the arm64 configs, so maybe (ARCH_MEDIATEK && !ARM64) || COMPILE_TEST? ->=20 +> > Same for mt2701 pinctrl. ->=20 -> http://kernel.opensuse.org/cgit/kernel-source/plain/config/arm64/default?= -id=3Dff90e915117c5d7a8bb00dc0bc1d3145ebe985ec +> +> http://kernel.opensuse.org/cgit/kernel-source/plain/config/arm64/default?id=ff90e915117c5d7a8bb00dc0bc1d3145ebe985ec Actually I thought the driver was needed primarily on arm64 because of this configuration file. If that's not the case then I can resubmit @@ -61,11 +58,11 @@ What about MT8135 and MT8173, are they 32-bit SoCs as well? > (...) > Anyway, a step forward, ->=20 -> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de> +> +> Reviewed-by: Andreas Färber <afaerber@suse.de> Thanks for the review. ---=20 +-- Jean Delvare SUSE L3 Support diff --git a/a/content_digest b/N1/content_digest index 67f264b..ac38e01 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,16 +14,16 @@ " Michael Turquette <mturquette@baylibre.com>\0" "\00:1\0" "b\0" - "On Mon, 9 Jan 2017 21:08:50 +0100, Andreas F=C3=A4rber wrote:\n" + "On Mon, 9 Jan 2017 21:08:50 +0100, Andreas F\303\244rber wrote:\n" "> Hi Jean,\n" - ">=20\n" + "> \n" "> Am 09.01.2017 um 11:36 schrieb Jean Delvare:\n" "> > If I say \"no\" to \"Clock driver for Mediatek MT2701\", I don't want to\n" "> > be asked individually about each sub-driver. No means no.\n" - "> >=20\n" + "> > \n" "> > Additionally, this driver shouldn't be proposed at all on non-mediatek\n" "> > builds, unless build-testing.\n" - "> >=20\n" + "> > \n" "> > Signed-off-by: Jean Delvare <jdelvare@suse.de>\n" "> > Fixes: e9862118272a (\"clk: mediatek: Add MT2701 clock support\")\n" "> > Cc: Shunli Wang <shunli.wang@mediatek.com>\n" @@ -36,7 +36,7 @@ "> [...]\n" "> > As another side note, I wonder why so many clock drivers have\n" "> > \"COMMON\" in their symbol names. Looks wrong to me.\n" - ">=20\n" + "> \n" "> It refers to the Common Clock Framework:\n" "> https://www.kernel.org/doc/Documentation/clk.txt\n" "\n" @@ -44,18 +44,16 @@ "everything with COMMON_CLK when the drivers live under drivers/clk, but\n" "oh well :-)\n" "\n" - "> > --- linux-4.10-rc2.orig/drivers/clk/mediatek/Kconfig\t2017-01-01 23:31:5=\n" - "3.000000000 +0100\n" - "> > +++ linux-4.10-rc2/drivers/clk/mediatek/Kconfig\t2017-01-09 11:17:37.542=\n" - "344083 +0100\n" + "> > --- linux-4.10-rc2.orig/drivers/clk/mediatek/Kconfig\t2017-01-01 23:31:53.000000000 +0100\n" + "> > +++ linux-4.10-rc2/drivers/clk/mediatek/Kconfig\t2017-01-09 11:17:37.542344083 +0100\n" "> > @@ -8,6 +8,7 @@ config COMMON_CLK_MEDIATEK\n" - "> > =20\n" + "> > \n" "> > config COMMON_CLK_MT2701\n" "> > \tbool \"Clock driver for Mediatek MT2701\"\n" "> > +\tdepends on ARCH_MEDIATEK || COMPILE_TEST\n" "> > \tselect COMMON_CLK_MEDIATEK\n" "> > \tdefault ARCH_MEDIATEK\n" - ">=20\n" + "> \n" "> Should the default then become y for simplicity?\n" "\n" "I left it as is as it is the same already done in other drivers in the\n" @@ -63,11 +61,10 @@ "\n" "> Another aspect here is that this is a 32-bit SoC but it propagates into\n" "> the arm64 configs, so maybe (ARCH_MEDIATEK && !ARM64) || COMPILE_TEST?\n" - ">=20\n" + "> \n" "> Same for mt2701 pinctrl.\n" - ">=20\n" - "> http://kernel.opensuse.org/cgit/kernel-source/plain/config/arm64/default?=\n" - "id=3Dff90e915117c5d7a8bb00dc0bc1d3145ebe985ec\n" + "> \n" + "> http://kernel.opensuse.org/cgit/kernel-source/plain/config/arm64/default?id=ff90e915117c5d7a8bb00dc0bc1d3145ebe985ec\n" "\n" "Actually I thought the driver was needed primarily on arm64 because of\n" "this configuration file. If that's not the case then I can resubmit\n" @@ -77,13 +74,13 @@ "\n" "> (...)\n" "> Anyway, a step forward,\n" - ">=20\n" - "> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>\n" + "> \n" + "> Reviewed-by: Andreas F\303\244rber <afaerber@suse.de>\n" "\n" "Thanks for the review.\n" "\n" - "--=20\n" + "-- \n" "Jean Delvare\n" SUSE L3 Support -cff36cbf3b0376c548975b9b44e63995c632670ac7b4fe9cc544b4e1e8b6cea2 +0bd640ef222ab07d806eb9a1ed076224822220402f5d42faa6ff816e008f3636
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.