From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:42264 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S936342AbdAJNsX (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 10 Jan 2017 08:48:23 -0500
Date: Tue, 10 Jan 2017 14:48:21 +0100
From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Paul Moore <paul@paul-moore.com>,
        Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 21/22] fsnotify: Add group pointer in fsnotify_init_mark()
Message-ID: <20170110134821.GQ4991@quack2.suse.cz>
References: <20170106104401.5894-1-jack@suse.cz>
 <20170106104401.5894-22-jack@suse.cz>
 <CAOQ4uxjMXp1qC9iQPXHhPhoB8m0+S-dCZxJ+wUJ672As=VVceA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOQ4uxjMXp1qC9iQPXHhPhoB8m0+S-dCZxJ+wUJ672As=VVceA@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun 08-01-17 14:35:51, Amir Goldstein wrote:
> On Fri, Jan 6, 2017 at 12:44 PM, Jan Kara <jack@suse.cz> wrote:
> > Currently we initialize mark->group only in fsnotify_add_mark_lock().
> > However we will need to access fsnotify_ops of corresponding group from
> > fsnotify_put_mark() so we need mark->group initialized earlier. Do that
> > in fsnotify_init_mark() which has a consequence that once
> > fsnotify_init_mark() is called on a mark, the mark has to be destroyed
> > by fsnotify_put_mark().
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> 
> The API change looks good to me, but as I wrote on v1,
> I rather that Paul reviews the changes in the audit code,
> which is the code that was missing the fsnotify_put_mark()
> calls.

OK. Paul?

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR