From: Oleg Nesterov <oleg@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: paul@paul-moore.com, selinux@tycho.nsa.gov,
yangshukui@huawei.com, casey@schaufler-ca.com,
linux-security-module@vger.kernel.org, james.l.morris@oracle.com
Subject: Re: [PATCH] security,selinux,smack: kill security_task_wait hook
Date: Tue, 10 Jan 2017 19:23:21 +0100 [thread overview]
Message-ID: <20170110182321.GA32298@redhat.com> (raw)
In-Reply-To: <1484069312-26653-1-git-send-email-sds@tycho.nsa.gov>
On 01/10, Stephen Smalley wrote:
>
> As reported by yangshukui, a permission denial from security_task_wait()
> can lead to a soft lockup in zap_pid_ns_processes() since it only expects
> sys_wait4() to return 0 or -ECHILD. Further, security_task_wait() can
> in general lead to zombies; in the absence of some way to automatically
> reparent a child process upon a denial, the hook is not useful. Remove
> the security hook and its implementations in SELinux and Smack. Smack
> already removed its check from its hook.
>
> Reported-by: yangshukui <yangshukui@huawei.com>
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Great ;)
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2017-01-10 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 17:28 [PATCH] security,selinux,smack: kill security_task_wait hook Stephen Smalley
2017-01-10 17:32 ` Casey Schaufler
2017-01-10 18:23 ` Oleg Nesterov [this message]
2017-01-12 16:03 ` Paul Moore
2017-01-12 16:49 ` Casey Schaufler
2017-01-12 17:00 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110182321.GA32298@redhat.com \
--to=oleg@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=james.l.morris@oracle.com \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=yangshukui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.