Re: Missing Patches in Linux Kernel RDMA

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

On Tue, Jan 10, 2017 at 11:51:35AM -0500, Doug Ledford wrote:
> On Tue, 2017-01-10 at 15:36 +0100, Christoph Hellwig wrote:
> > On Tue, Jan 10, 2017 at 04:30:18PM +0200, Leon Romanovsky wrote:
> > >
> > > The first patch which brought my attention was Christoph's change
> > > "IB: merge struct ib_device_attr into struct ib_device" [1].
> >
> > Doug decided to not kill off ib_device_attr entirely and just
> > embedded
> > it into the ib_device structure.
>
> Correct, I believe it was Or's patch that did that.

The original patch did more than just put all data into
ib_device. It removed the redundant parameter
(struct ib_device_attr *device_attr) from query_device().

Current code:
1883 struct ib_device {
....
1930         int                        (*query_device)(struct ib_device *device,
1931                                                    struct ib_device_attr *device_attr,
1932                                                    struct ib_udata *udata);

Do we want to continue that road and complete the cleanup?

>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]