From: Davidlohr Bueso <dave@stgolabs.net>
To: Oleg Nesterov <oleg@redhat.com>
Cc: mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] sched: Introduce rcuwait
Date: Tue, 10 Jan 2017 11:37:36 -0800 [thread overview]
Message-ID: <20170110193736.GA10639@linux-80c1.suse> (raw)
In-Reply-To: <20170110183547.GB32298@redhat.com>
On Tue, 10 Jan 2017, Oleg Nesterov wrote:
>Well, speaking of naming, rcuwait_trywake() doesn't look good to me,
>rcuwait_wake_up() looks better, "try" is misleading imo. But this is
>cosmetic/subjective too.
I actually added the 'try' on second thought -- in that for the particular
pcpu-rwsem user, obviously most of the time the wakeup will not actually
occur. But yeah, I'd have no problem just naming it rcuwait_wake_up().
>Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Thanks!
prev parent reply other threads:[~2017-01-10 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 17:01 [PATCH 0/2] sched: Introduce rcuwait Davidlohr Bueso
2016-12-22 17:01 ` [PATCH 1/2] sched: Introduce rcuwait machinery Davidlohr Bueso
2016-12-22 19:27 ` kbuild test robot
2017-01-03 23:20 ` Davidlohr Bueso
2016-12-22 19:55 ` kbuild test robot
2017-01-16 1:32 ` Davidlohr Bueso
2017-01-17 17:41 ` Oleg Nesterov
2016-12-22 17:01 ` [PATCH 2/2] locking/percpu-rwsem: Replace waitqueue with rcuwait Davidlohr Bueso
2017-01-09 18:26 ` [PATCH 0/2] sched: Introduce rcuwait Davidlohr Bueso
2017-01-10 18:35 ` Oleg Nesterov
2017-01-10 19:37 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110193736.GA10639@linux-80c1.suse \
--to=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.