All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Xiangliang Yu <Xiangliang.Yu@amd.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Allen Hubbe <Allen.Hubbe@emc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Style fixes: open code obfuscating macros
Date: Tue, 10 Jan 2017 16:55:28 -0500	[thread overview]
Message-ID: <20170110215527.GD13381@kudzu.us> (raw)
In-Reply-To: <1483407036-20697-1-git-send-email-logang@deltatee.com>

On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote:
> Hi,
> 
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
> suggested I fix the problem at the source.
> 
> Thus, please merge the following two patches to improve the style of
> the NTB drivers.
> 
> Thanks,
> 
> Logan

Applying the series, thanks

> 
> [1] http://www.spinics.net/lists/linux-pci/msg56904.html
> 
> 
> Logan Gunthorpe (2):
>   ntb_hw_amd: Style fixes: open code macros that just obfuscate code
>   ntb_hw_intel: Style fixes: open code macros that just obfuscate code
> 
>  drivers/ntb/hw/amd/ntb_hw_amd.c     |  59 ++++++++-------
>  drivers/ntb/hw/amd/ntb_hw_amd.h     |   3 -
>  drivers/ntb/hw/intel/ntb_hw_intel.c | 145 ++++++++++++++++++------------------
>  drivers/ntb/hw/intel/ntb_hw_intel.h |   3 -
>  4 files changed, 104 insertions(+), 106 deletions(-)
> 
> --
> 2.1.4

  parent reply	other threads:[~2017-01-10 21:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03  1:30 [PATCH 0/2] Style fixes: open code obfuscating macros Logan Gunthorpe
2017-01-03  1:30 ` [PATCH 1/2] ntb_hw_amd: Style fixes: open code macros that just obfuscate code Logan Gunthorpe
2017-01-03  1:30 ` [PATCH 2/2] ntb_hw_intel: " Logan Gunthorpe
2017-01-10 21:55 ` Jon Mason [this message]
2017-01-10 21:59   ` [PATCH 0/2] Style fixes: open code obfuscating macros Jon Mason
2017-01-10 23:06     ` Joe Perches
2017-01-10 23:34       ` Logan Gunthorpe
2017-01-11  6:50         ` Greg Kroah-Hartman
2017-01-11 17:48           ` Logan Gunthorpe
2017-01-15 22:38 ` jmrodriguezhw88
  -- strict thread matches above, loose matches on Subject: below --
2017-01-11  0:32 Logan Gunthorpe
2017-01-11  0:34 ` Logan Gunthorpe
2017-01-15 23:33 ` jmrodriguezhw88

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110215527.GD13381@kudzu.us \
    --to=jdmason@kudzu.us \
    --cc=Allen.Hubbe@emc.com \
    --cc=Xiangliang.Yu@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    --cc=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.