From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Date: Wed, 11 Jan 2017 17:05:04 +0200 Message-ID: <20170111150504.GK31595@intel.com> References: <20170104182859.GM31595@intel.com> <20170104183855.3852-1-fernetmenta@kodi.tv> <20170105113708.GN31595@intel.com> <88b5d93d-40df-9c1a-666e-9a3431833f88@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <88b5d93d-40df-9c1a-666e-9a3431833f88@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: ben@bwidawsk.net, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rainer Hochecker , fernetmenta@online.de List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKYW4gMDUsIDIwMTcgYXQgMDI6NDU6MzdQTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAwNS4wMS4yMDE3IHVtIDEyOjM3IHNjaHJpZWIgVmlsbGUgU3lyasOkbMOk Ogo+ID4gT24gV2VkLCBKYW4gMDQsIDIwMTcgYXQgMDc6Mzg6NTVQTSArMDEwMCwgUmFpbmVyIEhv Y2hlY2tlciB3cm90ZToKPiA+PiBGcm9tOiBSYWluZXIgSG9jaGVja2VyIDxmZXJuZXRtZW50YUBv bmxpbmUuZGU+Cj4gPj4KPiA+PiBUaGlzIGFkZHMgZm91cmNjIGNvZGVzIGZvciAxNmJpdCBwbGFu ZXMgcmVxdWlyZWQgZm9yIERSTSBidWZmZXIKPiA+PiBleHBvcnQgdG8gbWVzYS4KPiA+Pgo+ID4+ IFNpZ25lZC1vZmYtYnk6IFJhaW5lciBIb2NoZWNrZXIgPGZlcm5ldG1lbnRhQG9ubGluZS5kZT4K PiA+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+IAo+IEdvb2QgdG8gc2VlIHNvbWUgd29yayBsYW5kaW5nIG9uIHRoYXQgcGFydCwg cGF0Y2ggaXMgQWNrZWQtYnk6IENocmlzdGlhbiAKPiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4uCgpIYXMgdGhlIHVzZXJzcGFjZSBzaWRlIG9mIHRoaXMgYmVlbiByZXZpZXdlZCBh bHJlYWR5PwoKL21lIHdvbmRlcnMgaWYgaXQncyBzYWZlIHRvIHB1c2ggdGhpcy4uLgoKPiAKPiA+ Cj4gPj4gLS0tCj4gPj4gICBpbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaCB8IDcgKysrKysr Kwo+ID4+ICAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oIGIvaW5jbHVkZS91YXBpL2RybS9k cm1fZm91cmNjLmgKPiA+PiBpbmRleCBhNTg5MGJmLi5kMjMwZTU4IDEwMDY0NAo+ID4+IC0tLSBh L2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gPj4gKysrIGIvaW5jbHVkZS91YXBpL2Ry bS9kcm1fZm91cmNjLmgKPiA+PiBAQCAtNDEsMTAgKzQxLDE3IEBAIGV4dGVybiAiQyIgewo+ID4+ ICAgLyogOCBicHAgUmVkICovCj4gPj4gICAjZGVmaW5lIERSTV9GT1JNQVRfUjgJCWZvdXJjY19j b2RlKCdSJywgJzgnLCAnICcsICcgJykgLyogWzc6MF0gUiAqLwo+ID4+ICAgCj4gPj4gKy8qIDE2 IGJwcCBSZWQgKi8KPiA+PiArI2RlZmluZSBEUk1fRk9STUFUX1IxNgkJZm91cmNjX2NvZGUoJ1In LCAnMScsICc2JywgJyAnKSAvKiBbMTU6MF0gUiBsaXR0bGUgZW5kaWFuICovCj4gPj4gKwo+ID4+ ICAgLyogMTYgYnBwIFJHICovCj4gPj4gICAjZGVmaW5lIERSTV9GT1JNQVRfUkc4OAkJZm91cmNj X2NvZGUoJ1InLCAnRycsICc4JywgJzgnKSAvKiBbMTU6MF0gUjpHIDg6OCBsaXR0bGUgZW5kaWFu ICovCj4gPj4gICAjZGVmaW5lIERSTV9GT1JNQVRfR1I4OAkJZm91cmNjX2NvZGUoJ0cnLCAnUics ICc4JywgJzgnKSAvKiBbMTU6MF0gRzpSIDg6OCBsaXR0bGUgZW5kaWFuICovCj4gPj4gICAKPiA+ PiArLyogMzIgYnBwIFJHICovCj4gPj4gKyNkZWZpbmUgRFJNX0ZPUk1BVF9SRzE2MTYJZm91cmNj X2NvZGUoJ1InLCAnRycsICczJywgJzInKSAvKiBbMzE6MF0gUjpHIDE2OjE2IGxpdHRsZSBlbmRp YW4gKi8KPiA+PiArI2RlZmluZSBEUk1fRk9STUFUX0dSMTYxNglmb3VyY2NfY29kZSgnRycsICdS JywgJzMnLCAnMicpIC8qIFszMTowXSBHOlIgMTY6MTYgbGl0dGxlIGVuZGlhbiAqLwo+ID4+ICsK PiA+PiAgIC8qIDggYnBwIFJHQiAqLwo+ID4+ICAgI2RlZmluZSBEUk1fRk9STUFUX1JHQjMzMglm b3VyY2NfY29kZSgnUicsICdHJywgJ0InLCAnOCcpIC8qIFs3OjBdIFI6RzpCIDM6MzoyICovCj4g Pj4gICAjZGVmaW5lIERSTV9GT1JNQVRfQkdSMjMzCWZvdXJjY19jb2RlKCdCJywgJ0cnLCAnUics ICc4JykgLyogWzc6MF0gQjpHOlIgMjozOjMgKi8KPiA+PiAtLSAKPiA+PiAyLjkuMwo+IAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764128AbdAKPFo (ORCPT ); Wed, 11 Jan 2017 10:05:44 -0500 Received: from mga03.intel.com ([134.134.136.65]:61254 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdAKPFm (ORCPT ); Wed, 11 Jan 2017 10:05:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="29056234" Date: Wed, 11 Jan 2017 17:05:04 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Rainer Hochecker , ben@bwidawsk.net, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, fernetmenta@online.de Subject: Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Message-ID: <20170111150504.GK31595@intel.com> References: <20170104182859.GM31595@intel.com> <20170104183855.3852-1-fernetmenta@kodi.tv> <20170105113708.GN31595@intel.com> <88b5d93d-40df-9c1a-666e-9a3431833f88@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <88b5d93d-40df-9c1a-666e-9a3431833f88@vodafone.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote: > Am 05.01.2017 um 12:37 schrieb Ville Syrjälä: > > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> This adds fourcc codes for 16bit planes required for DRM buffer > >> export to mesa. > >> > >> Signed-off-by: Rainer Hochecker > > Reviewed-by: Ville Syrjälä > > Good to see some work landing on that part, patch is Acked-by: Christian > König . Has the userspace side of this been reviewed already? /me wonders if it's safe to push this... > > > > >> --- > >> include/uapi/drm/drm_fourcc.h | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > >> index a5890bf..d230e58 100644 > >> --- a/include/uapi/drm/drm_fourcc.h > >> +++ b/include/uapi/drm/drm_fourcc.h > >> @@ -41,10 +41,17 @@ extern "C" { > >> /* 8 bpp Red */ > >> #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ > >> > >> +/* 16 bpp Red */ > >> +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */ > >> + > >> /* 16 bpp RG */ > >> #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */ > >> #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */ > >> > >> +/* 32 bpp RG */ > >> +#define DRM_FORMAT_RG1616 fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */ > >> +#define DRM_FORMAT_GR1616 fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */ > >> + > >> /* 8 bpp RGB */ > >> #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */ > >> #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */ > >> -- > >> 2.9.3 > -- Ville Syrjälä Intel OTC