From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-liu@ti.com (Bin Liu) Date: Wed, 11 Jan 2017 14:08:11 -0600 Subject: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero In-Reply-To: <2733831484164533@web1g.yandex.ru> References: <20170103152534.20118-1-icenowy@aosc.xyz> <20170103152534.20118-5-icenowy@aosc.xyz> <20170110202443.GC2479@uda0271908> <2733831484164533@web1g.yandex.ru> Message-ID: <20170111200811.GA16865@uda0271908> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 12, 2017 at 03:55:33AM +0800, Icenowy Zheng wrote: > > > 11.01.2017, 04:24, "Bin Liu" : > > On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote: > >> ?Lichee Pi Zero features a USB OTG port. > >> > >> ?Add support for it. > >> > >> ?Note: in order to use the Host mode, the board must be powered via the > >> ?+5V and GND pins. > >> > >> ?Signed-off-by: Icenowy Zheng > >> ?--- > >> ??arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++ > >> ??1 file changed, 10 insertions(+) > >> > >> ?diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> ?index 0099affc6ce3..3d9168cbaeca 100644 > >> ?--- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> ?+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> ?@@ -71,3 +71,13 @@ > >> ??????????pinctrl-names = "default"; > >> ??????????status = "okay"; > >> ??}; > >> ?+ > >> ?+&usb_otg { > >> ?+ dr_mode = "otg"; > > > > Why not set this default mode in dtsi instead? > > > > Regards, > > -Bin. > > There's possibly boards which do not have OTG functions. That is board specific. You'd better to define the default dr_mode which the musb _controller_ supports in the dtsi, and then override it in a specific board dts if necessary. Regards, -Bin. > > Even the official CDR design of V3s uses the USB controller to > connect a UVC webcam to make the design a dual-cam design > (V3s itself has a CSI). > > > > >> ?+ status = "okay"; > >> ?+}; > >> ?+ > >> ?+&usbphy { > >> ?+ usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>; > >> ?+ status = "okay"; > >> ?+}; > >> ?-- > >> ?2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Date: Wed, 11 Jan 2017 14:08:11 -0600 Message-ID: <20170111200811.GA16865@uda0271908> References: <20170103152534.20118-1-icenowy@aosc.xyz> <20170103152534.20118-5-icenowy@aosc.xyz> <20170110202443.GC2479@uda0271908> <2733831484164533@web1g.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <2733831484164533@web1g.yandex.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Icenowy Zheng Cc: "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Chen-Yu Tsai , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, Jan 12, 2017 at 03:55:33AM +0800, Icenowy Zheng wrote: > = > = > 11.01.2017, 04:24, "Bin Liu" : > > On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote: > >> =A0Lichee Pi Zero features a USB OTG port. > >> > >> =A0Add support for it. > >> > >> =A0Note: in order to use the Host mode, the board must be powered via = the > >> =A0+5V and GND pins. > >> > >> =A0Signed-off-by: Icenowy Zheng > >> =A0--- > >> =A0=A0arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++ > >> =A0=A01 file changed, 10 insertions(+) > >> > >> =A0diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/a= rm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> =A0index 0099affc6ce3..3d9168cbaeca 100644 > >> =A0--- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> =A0+++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >> =A0@@ -71,3 +71,13 @@ > >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pinctrl-names =3D "default"; > >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0status =3D "okay"; > >> =A0=A0}; > >> =A0+ > >> =A0+&usb_otg { > >> =A0+ dr_mode =3D "otg"; > > > > Why not set this default mode in dtsi instead? > > > > Regards, > > -Bin. > = > There's possibly boards which do not have OTG functions. That is board specific. You'd better to define the default dr_mode which the musb _controller_ supports in the dtsi, and then override it in a specific board dts if necessary. Regards, -Bin. > = > Even the official CDR design of V3s uses the USB controller to > connect a UVC webcam to make the design a dual-cam design > (V3s itself has a CSI). > = > > > >> =A0+ status =3D "okay"; > >> =A0+}; > >> =A0+ > >> =A0+&usbphy { > >> =A0+ usb0_id_det-gpio =3D <&pio 5 6 GPIO_ACTIVE_HIGH>; > >> =A0+ status =3D "okay"; > >> =A0+}; > >> =A0-- > >> =A02.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934081AbdAKUJm (ORCPT ); Wed, 11 Jan 2017 15:09:42 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:56750 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbdAKUJk (ORCPT ); Wed, 11 Jan 2017 15:09:40 -0500 Date: Wed, 11 Jan 2017 14:08:11 -0600 From: Bin Liu To: Icenowy Zheng CC: Maxime Ripard , Chen-Yu Tsai , Kishon Vijay Abraham I , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Message-ID: <20170111200811.GA16865@uda0271908> Mail-Followup-To: Bin Liu , Icenowy Zheng , Maxime Ripard , Chen-Yu Tsai , Kishon Vijay Abraham I , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" References: <20170103152534.20118-1-icenowy@aosc.xyz> <20170103152534.20118-5-icenowy@aosc.xyz> <20170110202443.GC2479@uda0271908> <2733831484164533@web1g.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2733831484164533@web1g.yandex.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 03:55:33AM +0800, Icenowy Zheng wrote: > > > 11.01.2017, 04:24, "Bin Liu" : > > On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote: > >>  Lichee Pi Zero features a USB OTG port. > >> > >>  Add support for it. > >> > >>  Note: in order to use the Host mode, the board must be powered via the > >>  +5V and GND pins. > >> > >>  Signed-off-by: Icenowy Zheng > >>  --- > >>   arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++ > >>   1 file changed, 10 insertions(+) > >> > >>  diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  index 0099affc6ce3..3d9168cbaeca 100644 > >>  --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  @@ -71,3 +71,13 @@ > >>           pinctrl-names = "default"; > >>           status = "okay"; > >>   }; > >>  + > >>  +&usb_otg { > >>  + dr_mode = "otg"; > > > > Why not set this default mode in dtsi instead? > > > > Regards, > > -Bin. > > There's possibly boards which do not have OTG functions. That is board specific. You'd better to define the default dr_mode which the musb _controller_ supports in the dtsi, and then override it in a specific board dts if necessary. Regards, -Bin. > > Even the official CDR design of V3s uses the USB controller to > connect a UVC webcam to make the design a dual-cam design > (V3s itself has a CSI). > > > > >>  + status = "okay"; > >>  +}; > >>  + > >>  +&usbphy { > >>  + usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>; > >>  + status = "okay"; > >>  +}; > >>  -- > >>  2.11.0