All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Ken Goldman <kgoldman-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: TPM 2.0 RM flushcontext returning bad address
Date: Wed, 11 Jan 2017 14:55:31 -0700	[thread overview]
Message-ID: <20170111215531.GA30781@obsidianresearch.com> (raw)
In-Reply-To: <o561te$39p$1@blaine.gmane.org>

On Wed, Jan 11, 2017 at 02:43:50PM -0500, Ken Goldman wrote:

> I'll try again with additional reasons:

There is *always* going to be the possibility of errnos from TPM
command excution, it has to be handled. You can quibble if certain
specific cases should be errno or TPM errors, but we can't release the
mid layer from coping with this.

> - There's no guarantee that EBADF means "invalid handle".  I counted 17 
> EFAULT uses, most low level driver errors.  The TSS could mislead the user.

Yes, we'd have to audit the kernel if we go this way. As I said, the
possible errnos from ioctl would have to be well defined and properly
implemented in the kernel.

> Solution:
> 
> I suspect that the RM could just code:
> 
> 	if (can't map the transient handle for this connection)
> 		map it to TPM_RH_NULL
> 
> and let the TPM do the rest.

Sounds reasonable to me.

Jason

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi

      parent reply	other threads:[~2017-01-11 21:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 20:01 TPM 2.0 RM flushcontext Ken Goldman
2017-01-10 20:08 ` Jason Gunthorpe
     [not found]   ` <20170110200803.GB5102-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-10 22:31     ` TPM 2.0 RM flushcontext returning bad address Ken Goldman
2017-01-10 22:42       ` Jason Gunthorpe
     [not found]         ` <20170110224225.GA5451-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-01-11 11:38           ` Jarkko Sakkinen
2017-01-11 19:43           ` Ken Goldman
2017-01-11 19:56             ` James Bottomley
     [not found]               ` <1484164614.2509.31.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-11 20:29                 ` Ken Goldman
2017-01-14 16:45                 ` James Bottomley
     [not found]                   ` <1484412351.2424.7.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-01-14 18:19                     ` Ken Goldman
2017-01-14 18:32                       ` James Bottomley
2017-01-11 21:55             ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170111215531.GA30781@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=kgoldman-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.