From: Johan Hovold <johan@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Roman Sommer <roman.sommer@fau.de>,
devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
Christian Bewermeyer <christian.bewermeyer@fau.de>
Subject: Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
Date: Thu, 12 Jan 2017 09:47:38 +0100 [thread overview]
Message-ID: <20170112084738.GA26769@localhost> (raw)
In-Reply-To: <20170112070510.GC4239@mwanda>
On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote:
> On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> > Note that this patch does not fix all checkpatch warnings for the
> > affected files.
> >
>
> A lot of ways that display git commits put the changelog and the summary
> far apart. The changelog is pretty useless by itself in this case.
>
> https://lkml.org/lkml/2017/1/11/308
>
> See how it puts the date in between? marc.info is even worse but google
> hasn't indexed it yet and I'm too lazy to look it up. So people read
> the summary or the changelog but not necessarily both.
Yeah, let's do this right.
Roman, could you resend this with a self-contained commit message, and a
more compact summary (Subject) as I suggested earlier?
Thanks,
Johan
next prev parent reply other threads:[~2017-01-12 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
2017-01-10 16:40 ` Johan Hovold
2017-01-10 17:01 ` roman.sommer
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
2017-01-11 13:52 ` Johan Hovold
2017-01-11 14:44 ` roman.sommer
2017-01-11 14:47 ` roman.sommer
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
2017-01-11 15:08 ` Johan Hovold
2017-01-12 4:50 ` [greybus-dev] " Viresh Kumar
2017-01-12 7:05 ` Dan Carpenter
2017-01-12 8:47 ` Johan Hovold [this message]
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
2017-01-16 9:50 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112084738.GA26769@localhost \
--to=johan@kernel.org \
--cc=christian.bewermeyer@fau.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.sommer@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.