From: Johan Hovold <johan@kernel.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, johan@kernel.org
Subject: Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems
Date: Thu, 12 Jan 2017 10:07:53 +0100 [thread overview]
Message-ID: <20170112090753.GD7420@localhost> (raw)
In-Reply-To: <1484174751-19036-1-git-send-email-timur@codeaurora.org>
On Wed, Jan 11, 2017 at 04:45:51PM -0600, Timur Tabi wrote:
> Commit 6ffe1c4cd0a7 ("net: qcom/emac: fix of_node and phydev leaks")
> fixed the problem with reference leaks on phydev, but the fix is
> device-tree specific. When the driver unloads, the reference is
> dropped only on DT systems.
>
> Instead, it's cleaner if up grab an reference on ACPI systems.
> When the driver unloads, we can drop the reference without having
> to check whether we're on a DT system.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Reviewed-by: Johan Hovold <johan@kernel.org>
next prev parent reply other threads:[~2017-01-12 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 22:45 [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems Timur Tabi
2017-01-12 9:07 ` Johan Hovold [this message]
2017-01-12 20:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112090753.GD7420@localhost \
--to=johan@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.