From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bogdan Purcareata <bogdan.purcareata@gmail.com>
Cc: labbott@redhat.com, sumit.semwal@linaro.org,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters
Date: Thu, 12 Jan 2017 12:32:26 +0300 [thread overview]
Message-ID: <20170112093131.GC15314@mwanda> (raw)
In-Reply-To: <1484207659-22702-1-git-send-email-bogdan.purcareata@gmail.com>
On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote:
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
All staging patches need a changelog, no matter how trivial.
> ---
> drivers/staging/android/ion/ion-ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c
> index 7e7431d..e28fffb 100644
> --- a/drivers/staging/android/ion/ion-ioctl.c
> +++ b/drivers/staging/android/ion/ion-ioctl.c
> @@ -111,7 +111,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> struct ion_handle *handle;
>
> mutex_lock(&client->lock);
> - handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
> + handle = ion_handle_get_by_id_nolock(client,
> + data.handle.handle);
Please run checkpatch.pl over your patches before sending them. :P
regards,
dan carpenter
next prev parent reply other threads:[~2017-01-12 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 7:54 [PATCH 1/4] staging: android/ion: Fix line over 80 characters Bogdan Purcareata
2017-01-12 7:54 ` [PATCH 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata
2017-01-12 7:54 ` [PATCH 3/4] staging: android/ion: Align comment mark Bogdan Purcareata
2017-01-12 7:54 ` [PATCH 4/4] staging: android/ion: Use variable names in header Bogdan Purcareata
2017-01-12 9:32 ` Dan Carpenter [this message]
2017-01-12 9:56 ` [PATCH 1/4] staging: android/ion: Fix line over 80 characters Greg KH
2017-01-12 21:45 ` Bogdan Purcareata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112093131.GC15314@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=bogdan.purcareata@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.