From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private Date: Thu, 12 Jan 2017 15:37:40 +0100 Message-ID: <20170112143740.GA15806@ulmo.ba.sec> References: <1482835765-12044-1-git-send-email-daniel.vetter@ffwll.ch> <1482835765-12044-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0122373391==" Return-path: Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB94E6E41E for ; Thu, 12 Jan 2017 14:37:44 +0000 (UTC) Received: by mail-lf0-x242.google.com with SMTP id q89so2102268lfi.1 for ; Thu, 12 Jan 2017 06:37:44 -0800 (PST) In-Reply-To: <1482835765-12044-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0122373391== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 27, 2016 at 11:49:25AM +0100, Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But tegra is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant. Nit: "Tegra", "redundant", "FB"? >=20 > One caveat here is that the failur path in the init code still "failure" > manually cleaned up the fb. I presume that was an oversigth and "oversight" > changed it over to drm_framebuffer_remove too. >=20 > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/fb.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Yes, drm_framebuffer_remove() ends up calling tegra_fb_destroy(), which is really what we need here, so: Acked-by: Thierry Reding --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlh3lLEACgkQ3SOs138+ s6HpBw/+MFEw6bTkyXrPeSkLntNUYeb/hulFXFt2BvJ7kFigw6iOHfx4ZmZNpklO CwMdzJB8BpW4ZlrU+jvttJ6kSV8XTlHUMukHn0CkwcykD9XEH93QBTgxDDRVE+Rs WMe5ZkJlA0ol1zNUxaSQu7XzwY8KXseE8tnKjmzIidjBRTYfnQmd/VocODP0vxJy jpDmbxUl3MZ9kmi2HiN0Ayzbu3zfHfmeGRcpxMoTmlLBLhgLpjjjtI4c5db4dsuJ 8MMZYJYOuCIV3ZckO+BshkD9MpkpMbpeWNMnllXDG+oE4WnZ+m5Nmvg8jOmo86PM zC9KuGcou3AVcLZYBCBo6ipaLZxWVbGwHfDQXnDypJoRwTz3BU1hHbONIAGuHZ3G s3HCfeLDiMJrtyCfWD1ndELDbwQBd/P4jbtGUdVz/x63CSQwF980L9GCYBsAgsiQ MggabVNgkSMeO0Ueo9N0/5SnLSXQ37wnfEuajYIo5yZ8xMnVdrCb/zyx4/hU8BHJ kGrRLyLDkWC7SSzqjBJMKZwUb6gQrIFpqX8KVmcPq+QNiYQTwZF9Ltez1U9V+4O1 Wo0agVyCL/A7+VyC3WIOdhePFSjZvJrPV0M9Bqmpc6EolTv4ZYOigODTB3GFt8VY YR+cc9Bfo6TxMnnlQ53ia36BYIHTFXkibE7rQMHI/6GCrl0SGAY= =eaUp -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf-- --===============0122373391== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0122373391==--