From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harsh Jain <Harsh@chelsio.com>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106
Date: Fri, 13 Jan 2017 00:42:55 +0800 [thread overview]
Message-ID: <20170112164255.GF20085@gondor.apana.org.au> (raw)
In-Reply-To: <648404c5-4234-7895-d478-858433b0d093@chelsio.com>
On Thu, Jan 12, 2017 at 10:08:46PM +0530, Harsh Jain wrote:
>
> That case is already handled in next if condition.It will error out with -EINVAL in next condition.
>
> if (keylen == AES_KEYSIZE_128) {
Good point. Please split the patches according to whether they
should go into 4.10/4.11 and then resubmit.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-01-12 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 8:31 [PATCH v1 0/8] crypto:chcr- Bug fixes Harsh Jain
2017-01-06 8:31 ` [PATCH v1 1/8] crypto:chcr-Change flow IDs Harsh Jain
2017-01-06 8:31 ` [PATCH v1 2/8] crypto:chcr- Fix panic on dma_unmap_sg Harsh Jain
2017-01-06 8:31 ` [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106 Harsh Jain
2017-01-12 16:09 ` Herbert Xu
2017-01-12 16:38 ` Harsh Jain
2017-01-12 16:42 ` Herbert Xu [this message]
2017-01-06 8:31 ` [PATCH v1 4/8] crypto:chcr- Use cipher instead of Block Cipher in gcm setkey Harsh Jain
2017-01-06 8:31 ` [PATCH v1 5/8] crypto:chcr: Change cra_flags for cipher algos Harsh Jain
2017-01-06 8:31 ` [PATCH v1 6/8] crypto:chcr- Change algo priority Harsh Jain
2017-01-06 8:31 ` [PATCH v1 7/8] crypto:chcr- Check device is allocated before use Harsh Jain
2017-01-06 8:31 ` [PATCH v1 8/8] crypto:chcr- Fix wrong typecasting Harsh Jain
2017-01-12 16:14 ` [PATCH v1 0/8] crypto:chcr- Bug fixes Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112164255.GF20085@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Harsh@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.