From: "Bill O'Donnell" <billodo@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] build: add .tar.xz target
Date: Thu, 12 Jan 2017 13:06:26 -0600 [thread overview]
Message-ID: <20170112190626.GB17868@redhat.com> (raw)
In-Reply-To: <d8bdc1f2-af99-f7fd-659b-45f7ebf36efb@sandeen.net>
On Thu, Jan 12, 2017 at 11:14:52AM -0600, Eric Sandeen wrote:
> kup generates .xz files, and Fedora RPMs now use that.
> It'd be nice to have a handy target to generate .xz
> files locally, so hack that in.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> I imagine there's a prettier way with wildcards or
> templates or whatnot, but my Make is rusty.
>
> Makefile | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 84dc62c..6e45733 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -26,18 +26,19 @@ endif
>
> SRCDIR = $(PKG_NAME)-$(PKG_VERSION)
> SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
> +SRCTARXZ = $(PKG_NAME)-$(PKG_VERSION).tar.xz
>
> CONFIGURE = aclocal.m4 configure config.guess config.sub install-sh ltmain.sh
> LSRCFILES = configure.ac release.sh README VERSION $(CONFIGURE)
> SRCTARINC = m4/libtool.m4 m4/lt~obsolete.m4 m4/ltoptions.m4 m4/ltsugar.m4 \
> m4/ltversion.m4 po/xfsprogs.pot .gitcensus $(CONFIGURE)
> LDIRT = config.log .ltdep .dep config.status config.cache confdefs.h \
> - conftest* built .census install.* install-dev.* *.gz \
> + conftest* built .census install.* install-dev.* *.gz *.xz \
> autom4te.cache/* libtool include/builddefs include/platform_defs.h
>
> ifeq ($(HAVE_BUILDDEFS), yes)
> LDIRDIRT = $(SRCDIR)
> -LDIRT += $(SRCTAR)
> +LDIRT += $(SRCTAR) $(SRCTARXZ)
> endif
>
> # header install rules to populate include/xfs correctly
> @@ -165,6 +166,11 @@ $(SRCTAR) : default $(SRCTARINC) .gitcensus
> `cat .gitcensus` $(SRCTARINC)
> echo Wrote: $@
>
> +$(SRCTARXZ) : default $(SRCTARINC) .gitcensus
> + $(Q)$(TAR) --transform "s,^,$(SRCDIR)/," -Jcf $(SRCDIR).tar.xz \
> + `cat .gitcensus` $(SRCTARINC)
> + echo Wrote: $@
> +
> .gitcensus: $(_FORCE)
> $(Q)if test -d .git; then \
> git ls-files > .gitcensus && echo "new .gitcensus"; \
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-12 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 17:08 [PATCH 0/3] xfsprogs: small fixes Eric Sandeen
2017-01-12 17:13 ` [PATCH 1/3] Update licenses in COPYING file Eric Sandeen
2017-01-12 17:46 ` Alex Elder
2017-01-12 18:43 ` [PATCH 1/3 V2] Clean up license text " Eric Sandeen
2017-01-12 19:05 ` Bill O'Donnell
2017-01-12 17:14 ` [PATCH 2/3] build: add .tar.xz target Eric Sandeen
2017-01-12 19:06 ` Bill O'Donnell [this message]
2017-01-12 17:15 ` [PATCH 3/3] libxfs-apply: minor improvements Eric Sandeen
2017-01-12 19:08 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112190626.GB17868@redhat.com \
--to=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.